|
|
Created:
4 years ago by sammiequon Modified:
3 years, 8 months ago CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptioncros: Remaining interfaces for DBUS biometrics client.
Add the auth session, enroll session and record clients.
Part 2 of a 5 patch series:
https://codereview.chromium.org/2567813002/ Adds biometrics manager interface
https://codereview.chromium.org/2581403002/ Adds other interfaces <<<
https://codereview.chromium.org/2578323004/ Adds fake clients
https://codereview.chromium.org/2646793003/ Hook up to chromeos
https://codereview.chromium.org/2644233002/ Add a fake implemntation
TEST=chromeos_unittest --gtest_filter="BiodClientTest.*"
BUG=702675
Review-Url: https://codereview.chromium.org/2581403002
Cr-Commit-Position: refs/heads/master@{#462171}
Committed: https://chromium.googlesource.com/chromium/src/+/7b2183284d955be12c2662bbcb0752393a0861d9
Patch Set 1 #Patch Set 2 : Updated naming. #Patch Set 3 : Rebased to master. #Patch Set 4 : Remove chromeos.gyp. #
Total comments: 6
Patch Set 5 : Rebased. #Patch Set 6 : Patch set 4 fixes. #Patch Set 7 : Rebased. #
Total comments: 10
Patch Set 8 : Fixed patch set 7 errors. #
Total comments: 2
Patch Set 9 : Fix patch set 8 errors. #
Total comments: 10
Patch Set 10 : Rebased. #
Total comments: 1
Patch Set 11 : Removed extra files. #
Total comments: 8
Patch Set 12 : Fixed patch set 11 errors. #Patch Set 13 : Rebased. #
Dependent Patchsets: Messages
Total messages: 47 (23 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== cros: Remaining interfaces for DBUS biometrics client. BUG= ========== to ========== cros: Remaining interfaces for DBUS biometrics client. BUG= ==========
sammiequon@chromium.org changed reviewers: + steel@chromium.org
Description was changed from ========== cros: Remaining interfaces for DBUS biometrics client. BUG= ========== to ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. TEST=none BUG=702675 ==========
steel@ - Please take a look. Thanks!
rkc@chromium.org changed reviewers: + rkc@chromium.org
https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_auth... File chromeos/dbus/biod_auth_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_auth... chromeos/dbus/biod_auth_session_client.cc:56: DBusClientImplementationType type) { /* type */ https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_enro... File chromeos/dbus/biod_enroll_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_enro... chromeos/dbus/biod_enroll_session_client.cc:56: DBusClientImplementationType type) { /* type */ that or you can completely skip putting this argument into place and add it in the CL that actually uses it. Either is fine. https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_reco... File chromeos/dbus/biod_record_client.h (right): https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_reco... chromeos/dbus/biod_record_client.h:41: // function. This is a BLOCKING CALL. Why is this a blocking call? Also nit: no need for caps.
BTW, with chained patches like this, it is helpful to have a list of all the patches in the description, with the current patch being pointed out. See http://crrev.com/1915803002/ for an example.
Description was changed from ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. TEST=none BUG=702675 ========== to ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 1 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=none BUG=702675 ==========
https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_auth... File chromeos/dbus/biod_auth_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_auth... chromeos/dbus/biod_auth_session_client.cc:56: DBusClientImplementationType type) { On 2017/03/20 23:47:09, rkc wrote: > /* type */ Done. https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_enro... File chromeos/dbus/biod_enroll_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_enro... chromeos/dbus/biod_enroll_session_client.cc:56: DBusClientImplementationType type) { On 2017/03/20 23:47:09, rkc wrote: > /* type */ > that or you can completely skip putting this argument into place and add it in > the CL that actually uses it. Either is fine. Done. https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_reco... File chromeos/dbus/biod_record_client.h (right): https://codereview.chromium.org/2581403002/diff/80001/chromeos/dbus/biod_reco... chromeos/dbus/biod_record_client.h:41: // function. This is a BLOCKING CALL. On 2017/03/20 23:47:09, rkc wrote: > Why is this a blocking call? > Also nit: no need for caps. This is a version of the previous function in case someone wants to the label without binding a callback.
sammiequon@chromium.org changed reviewers: + stevenjb@chromium.org
stevenjb@ - Please take a look. Thanks!
Please be sure to have someone familiar with the feature (rkc?) also review this. https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... File chromeos/dbus/biod_auth_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... chromeos/dbus/biod_auth_session_client.cc:45: base::WeakPtrFactory<BiodAuthSessionClientImpl> weak_ptr_factory_; Unused? https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... File chromeos/dbus/biod_auth_session_client.h (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... chromeos/dbus/biod_auth_session_client.h:26: virtual void End(const dbus::ObjectPath& auth_session_path) = 0; nit: Maybe EndAuthSession? 'End' is kind of vague. https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_enr... File chromeos/dbus/biod_enroll_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_enr... chromeos/dbus/biod_enroll_session_client.cc:45: base::WeakPtrFactory<BiodEnrollSessionClientImpl> weak_ptr_factory_; Unused? https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_rec... File chromeos/dbus/biod_record_client.cc (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.cc:72: dbus::MessageReader reader(response); I forget what happens if the request fails, do we need to check the response? I guess it will just fail in reader.Pop...? https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.cc:75: callback.Run(result); We should log an error and call the callback with an empty or error result on failure, otherwise code expecting a result might just stick around waiting.
yeah, I'll be sure to wait for rkc's lgtm before proceeding https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... File chromeos/dbus/biod_auth_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... chromeos/dbus/biod_auth_session_client.cc:45: base::WeakPtrFactory<BiodAuthSessionClientImpl> weak_ptr_factory_; On 2017/03/22 20:57:53, stevenjb wrote: > Unused? Done. https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... File chromeos/dbus/biod_auth_session_client.h (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_aut... chromeos/dbus/biod_auth_session_client.h:26: virtual void End(const dbus::ObjectPath& auth_session_path) = 0; On 2017/03/22 20:57:53, stevenjb wrote: > nit: Maybe EndAuthSession? 'End' is kind of vague. Done. https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_enr... File chromeos/dbus/biod_enroll_session_client.cc (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_enr... chromeos/dbus/biod_enroll_session_client.cc:45: base::WeakPtrFactory<BiodEnrollSessionClientImpl> weak_ptr_factory_; On 2017/03/22 20:57:53, stevenjb wrote: > Unused? Done. https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_rec... File chromeos/dbus/biod_record_client.cc (right): https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.cc:72: dbus::MessageReader reader(response); On 2017/03/22 20:57:53, stevenjb wrote: > I forget what happens if the request fails, do we need to check the response? I > guess it will just fail in reader.Pop...? It seems like response might be empty and it could also fail while reading the response. https://codereview.chromium.org/2581403002/diff/140001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.cc:75: callback.Run(result); On 2017/03/22 20:57:53, stevenjb wrote: > We should log an error and call the callback with an empty or error result on > failure, otherwise code expecting a result might just stick around waiting. Done.
https://codereview.chromium.org/2581403002/diff/160001/chromeos/dbus/biod_rec... File chromeos/dbus/biod_record_client.cc (right): https://codereview.chromium.org/2581403002/diff/160001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.cc:76: LOG(ERROR) << "Error calling " << biod::kRecordLabelProperty; Shouldn't we check this before constructing |reader| in line 73? We can call callback.Run("") and early exit in that case.
https://codereview.chromium.org/2581403002/diff/160001/chromeos/dbus/biod_rec... File chromeos/dbus/biod_record_client.cc (right): https://codereview.chromium.org/2581403002/diff/160001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.cc:76: LOG(ERROR) << "Error calling " << biod::kRecordLabelProperty; On 2017/03/23 20:23:34, stevenjb wrote: > Shouldn't we check this before constructing |reader| in line 73? We can call > callback.Run("") and early exit in that case. > Done.
owner lgtm
On 2017/03/23 21:14:57, stevenjb wrote: > owner lgtm Thanks! rkc@ - Please take another look. Thanks!
https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_aut... File chromeos/dbus/biod_auth_session_client.h (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_aut... chromeos/dbus/biod_auth_session_client.h:26: virtual void EndAuthSession(const dbus::ObjectPath& auth_session_path) = 0; Any reason why we are diverging the names from the D-Bus API? https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_bio... File chromeos/dbus/biod_biometrics_manager_client_unittest.cc (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_bio... chromeos/dbus/biod_biometrics_manager_client_unittest.cc:1: // Copyright 2017 The Chromium Authors. All rights reserved. nit: You should probably fix this in the previous patch :) https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_enr... File chromeos/dbus/biod_enroll_session_client.h (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_enr... chromeos/dbus/biod_enroll_session_client.h:26: virtual void CancelEnrollSession( Same as last comment. Being part of BiodEnrollSessionClient, this can just be "Cancel" and still convey the same meaning. https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_rec... File chromeos/dbus/biod_record_client.h (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.h:30: virtual void SetRecordLabel(const dbus::ObjectPath& record_path, SetLabel here and Remove below should suffice. https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.h:39: virtual void RequestRecordLabel(const dbus::ObjectPath& record_path, This doesn't seem to exist in the D-Bus API at https://www.chromium.org/chromium-os/packages/biod (or the gerrit CL).
sammiequon@chromium.org changed reviewers: + derat@chromium.org
derat@ - Do you mind taking a look at the other CLs in this series? Thanks! https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_aut... File chromeos/dbus/biod_auth_session_client.h (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_aut... chromeos/dbus/biod_auth_session_client.h:26: virtual void EndAuthSession(const dbus::ObjectPath& auth_session_path) = 0; On 2017/03/25 00:41:37, rkc wrote: > Any reason why we are diverging the names from the D-Bus API? I've changed them back. https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_bio... File chromeos/dbus/biod_biometrics_manager_client_unittest.cc (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_bio... chromeos/dbus/biod_biometrics_manager_client_unittest.cc:1: // Copyright 2017 The Chromium Authors. All rights reserved. On 2017/03/25 00:41:38, rkc wrote: > nit: You should probably fix this in the previous patch :) Done. https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_enr... File chromeos/dbus/biod_enroll_session_client.h (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_enr... chromeos/dbus/biod_enroll_session_client.h:26: virtual void CancelEnrollSession( On 2017/03/25 00:41:38, rkc wrote: > Same as last comment. Being part of BiodEnrollSessionClient, this can just be > "Cancel" and still convey the same meaning. Done. https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_rec... File chromeos/dbus/biod_record_client.h (right): https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.h:30: virtual void SetRecordLabel(const dbus::ObjectPath& record_path, On 2017/03/25 00:41:38, rkc wrote: > SetLabel here and Remove below should suffice. Done. https://codereview.chromium.org/2581403002/diff/180001/chromeos/dbus/biod_rec... chromeos/dbus/biod_record_client.h:39: virtual void RequestRecordLabel(const dbus::ObjectPath& record_path, On 2017/03/25 00:41:38, rkc wrote: > This doesn't seem to exist in the D-Bus API at > https://www.chromium.org/chromium-os/packages/biod (or the gerrit CL). It's the property at [1]. [1] https://cs.chromium.org/chromium/src/third_party/cros_system_api/dbus/service...
re the commit message, this actually patch #2 rather than #1 in the series, right? https://codereview.chromium.org/2581403002/diff/200001/chromeos/dbus/biod/bio... File chromeos/dbus/biod/biod_auth_session_client.h (right): https://codereview.chromium.org/2581403002/diff/200001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_auth_session_client.h:22: class CHROMEOS_EXPORT BiodAuthSessionClient : public DBusClient { i don't think it makes sense to add classes for these other clients if there's only going to be one of each of them and each will only have one (or very few) methods. i'd recommend just adding new methods to BiodClient instead, e.g.: virtual void EndAuthSession(const dbus::ObjectPath auth_session_path) = 0;
Description was changed from ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 1 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=none BUG=702675 ========== to ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 2 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=none BUG=702675 ==========
Patchset #11 (id:220001) has been deleted
Description was changed from ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 2 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=none BUG=702675 ========== to ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 2 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=chromeos_unittest --gtest_filter="BiodClientTest.*" BUG=702675 ==========
On 2017/04/03 18:02:10, Daniel Erat wrote: > re the commit message, this actually patch #2 rather than #1 in the series, > right? > > https://codereview.chromium.org/2581403002/diff/200001/chromeos/dbus/biod/bio... > File chromeos/dbus/biod/biod_auth_session_client.h (right): > > https://codereview.chromium.org/2581403002/diff/200001/chromeos/dbus/biod/bio... > chromeos/dbus/biod/biod_auth_session_client.h:22: class CHROMEOS_EXPORT > BiodAuthSessionClient : public DBusClient { > i don't think it makes sense to add classes for these other clients if there's > only going to be one of each of them and each will only have one (or very few) > methods. > > i'd recommend just adding new methods to BiodClient instead, e.g.: > > virtual void EndAuthSession(const dbus::ObjectPath auth_session_path) = 0; Yeah its path #2, oops. I consolidated all the files into the main one. Thanks, it's a lot cleaner now :-).
https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... File chromeos/dbus/biod/biod_client.cc (right): https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.cc:343: dbus::Bus* bus_; nit: add " = nullptr;" here https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.cc:344: dbus::ObjectProxy* biod_proxy_; and here (you'll need to remove initialization from the c'tor) https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... File chromeos/dbus/biod/biod_client.h (right): https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.h:80: // LabelCallback is for the RequestLabel method. It receives one argument RequestRecordLabel https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.h:82: using LabelCallback = base::Callback<void(const std::string&)>; i think you can include a parameter name here, e.g. using LabelCallback = base::Callback<void(const std::string& label)>; you can delete the second sentence of the comment, then.
https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... File chromeos/dbus/biod/biod_client.cc (right): https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.cc:343: dbus::Bus* bus_; On 2017/04/03 19:58:18, Daniel Erat wrote: > nit: add " = nullptr;" here Done. https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.cc:344: dbus::ObjectProxy* biod_proxy_; On 2017/04/03 19:58:18, Daniel Erat wrote: > and here (you'll need to remove initialization from the c'tor) Done. https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... File chromeos/dbus/biod/biod_client.h (right): https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.h:80: // LabelCallback is for the RequestLabel method. It receives one argument On 2017/04/03 19:58:18, Daniel Erat wrote: > RequestRecordLabel Done. https://codereview.chromium.org/2581403002/diff/240001/chromeos/dbus/biod/bio... chromeos/dbus/biod/biod_client.h:82: using LabelCallback = base::Callback<void(const std::string&)>; On 2017/04/03 19:58:18, Daniel Erat wrote: > i think you can include a parameter name here, e.g. > > using LabelCallback = base::Callback<void(const std::string& label)>; > > you can delete the second sentence of the comment, then. Done.
lgtm
On 2017/04/03 22:31:10, Daniel Erat wrote: > lgtm Thanks!
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/03 23:02:56, sammiequon wrote: > On 2017/04/03 22:31:10, Daniel Erat wrote: > > lgtm > > Thanks! rkc@ - Do you want to take another look?
lgtm
On 2017/04/05 18:16:40, rkc wrote: > lgtm Thanks!
The CQ bit was checked by sammiequon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org, derat@chromium.org Link to the patchset: https://codereview.chromium.org/2581403002/#ps280001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 280001, "attempt_start_ts": 1491416883024160, "parent_rev": "878ac4d2acc8771023bbfb167cc071a5f1455470", "commit_rev": "7b2183284d955be12c2662bbcb0752393a0861d9"}
Message was sent while issue was closed.
Description was changed from ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 2 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=chromeos_unittest --gtest_filter="BiodClientTest.*" BUG=702675 ========== to ========== cros: Remaining interfaces for DBUS biometrics client. Add the auth session, enroll session and record clients. Part 2 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface https://codereview.chromium.org/2581403002/ Adds other interfaces <<< https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=chromeos_unittest --gtest_filter="BiodClientTest.*" BUG=702675 Review-Url: https://codereview.chromium.org/2581403002 Cr-Commit-Position: refs/heads/master@{#462171} Committed: https://chromium.googlesource.com/chromium/src/+/7b2183284d955be12c2662bbcb07... ==========
Message was sent while issue was closed.
Committed patchset #13 (id:280001) as https://chromium.googlesource.com/chromium/src/+/7b2183284d955be12c2662bbcb07... |