cros: Add biod interfaces to dbus thread manager.

cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

Part 4 of a 5 patch series:
https://codereview.chromium.org/2567813002/ Adds biometrics manager interface
https://codereview.chromium.org/2581403002/ Adds other interfaces
https://codereview.chromium.org/2578323004/ Adds fake clients
https://codereview.chromium.org/2646793003/ Hook up to chromeos <<<
https://codereview.chromium.org/2644233002/ Add a fake implemntation

BUG=702675
TEST=none

Review-Url: https://codereview.chromium.org/2646793003
Cr-Commit-Position: refs/heads/master@{#462503}
Committed: https://chromium.googlesource.com/chromium/src/+/64b97d90659819f974799112e045fccdf7c6bf79

[sammiequon, 2017-03-17 18:54:43]

Description was changed from

==========
cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

BUG=672269
TEST=none
==========

to

==========
cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

BUG=702675
TEST=none
==========

[sammiequon, 2017-03-17 18:54:43]

sammiequon@chromium.org changed reviewers:
+ steel@chromium.org

[sammiequon, 2017-03-17 18:55:08]

steel@ - Please take a look. Thanks!

[sammiequon, 2017-03-21 00:14:38]

Description was changed from

==========
cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

BUG=702675
TEST=none
==========

to

==========
cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

Part 4 of a 5 patch series:
https://codereview.chromium.org/2567813002/ Adds biometrics manager interface
https://codereview.chromium.org/2581403002/ Adds other interfaces
https://codereview.chromium.org/2578323004/ Adds fake clients
https://codereview.chromium.org/2646793003/ Hook up to chromeos <<<
https://codereview.chromium.org/2644233002/ Add a fake implemntation

BUG=702675
TEST=none
==========

[rkc, 2017-03-21 00:15:04]

rkc@chromium.org changed reviewers:
+ rkc@chromium.org

[rkc, 2017-03-21 00:15:04]

lgtm

[sammiequon, 2017-03-21 01:10:32]

Thanks!

[sammiequon, 2017-04-04 18:51:58]

sammiequon@chromium.org changed reviewers:
+ stevenjb@chromium.org

[sammiequon, 2017-04-04 18:52:22]

stevenjb@ - Please take a look. Thanks!

[stevenjb, 2017-04-05 16:36:21]

lgtm w/ one suggestion

https://codereview.chromium.org/2646793003/diff/40001/chromeos/dbus/dbus_clie...
File chromeos/dbus/dbus_clients_common.cc (right):

https://codereview.chromium.org/2646793003/diff/40001/chromeos/dbus/dbus_clie...
chromeos/dbus/dbus_clients_common.cc:48: : FAKE_DBUS_CLIENT_IMPLEMENTATION));
We use this pattern enough now that we should set a local to REAL or FAKE and
just pass it here and below.

[sammiequon, 2017-04-05 17:53:27]

Thanks!

https://codereview.chromium.org/2646793003/diff/40001/chromeos/dbus/dbus_clie...
File chromeos/dbus/dbus_clients_common.cc (right):

https://codereview.chromium.org/2646793003/diff/40001/chromeos/dbus/dbus_clie...
chromeos/dbus/dbus_clients_common.cc:48: : FAKE_DBUS_CLIENT_IMPLEMENTATION));
On 2017/04/05 16:36:20, stevenjb wrote:
> We use this pattern enough now that we should set a local to REAL or FAKE and
> just pass it here and below.

Done.

[stevenjb, 2017-04-05 18:01:58]

thanks! still lgtm

[sammiequon, 2017-04-05 18:49:44]

sammiequon@chromium.org changed reviewers:
+ derat@chromium.org

[sammiequon, 2017-04-05 18:49:58]

derat@ - Please take a look. Thanks!

[Daniel Erat, 2017-04-05 19:34:28]

lgtm

https://codereview.chromium.org/2646793003/diff/60001/chromeos/dbus/dbus_clie...
File chromeos/dbus/dbus_clients_common.cc (right):

https://codereview.chromium.org/2646793003/diff/60001/chromeos/dbus/dbus_clie...
chromeos/dbus/dbus_clients_common.cc:46: DBusClientImplementationType
client_impl_type =
nit: consider marking this const

[sammiequon, 2017-04-06 05:11:06]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 05:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sammiequon, 2017-04-06 05:12:11]

Thanks!

https://codereview.chromium.org/2646793003/diff/60001/chromeos/dbus/dbus_clie...
File chromeos/dbus/dbus_clients_common.cc (right):

https://codereview.chromium.org/2646793003/diff/60001/chromeos/dbus/dbus_clie...
chromeos/dbus/dbus_clients_common.cc:46: DBusClientImplementationType
client_impl_type =
On 2017/04/05 19:34:27, Daniel Erat wrote:
> nit: consider marking this const

Good idea. Done.

[commit-bot: I haz the power, 2017-04-06 06:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 06:26:20]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-04-06 15:33:40]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2017-04-06 15:33:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rkc@chromium.org,
stevenjb@chromium.org, derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2646793003/#ps80001
(title: "Change to const.")

[commit-bot: I haz the power, 2017-04-06 15:34:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:36:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491492820521690,
"parent_rev": "8d547e161dbe03d5887207c72c3bc4af33fbfea0", "commit_rev":
"64b97d90659819f974799112e045fccdf7c6bf79"}

[commit-bot: I haz the power, 2017-04-06 16:37:49]

Description was changed from

==========
cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

Part 4 of a 5 patch series:
https://codereview.chromium.org/2567813002/ Adds biometrics manager interface
https://codereview.chromium.org/2581403002/ Adds other interfaces
https://codereview.chromium.org/2578323004/ Adds fake clients
https://codereview.chromium.org/2646793003/ Hook up to chromeos <<<
https://codereview.chromium.org/2644233002/ Add a fake implemntation

BUG=702675
TEST=none
==========

to

==========
cros: Add biod interfaces to dbus thread manager.

Previously biod interfaces were not used in the code except their unit tests.

Part 4 of a 5 patch series:
https://codereview.chromium.org/2567813002/ Adds biometrics manager interface
https://codereview.chromium.org/2581403002/ Adds other interfaces
https://codereview.chromium.org/2578323004/ Adds fake clients
https://codereview.chromium.org/2646793003/ Hook up to chromeos <<<
https://codereview.chromium.org/2644233002/ Add a fake implemntation

BUG=702675
TEST=none

Review-Url: https://codereview.chromium.org/2646793003
Cr-Commit-Position: refs/heads/master@{#462503}
Committed:
https://chromium.googlesource.com/chromium/src/+/64b97d90659819f974799112e045...
==========

[commit-bot: I haz the power, 2017-04-06 16:37:50]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/64b97d90659819f974799112e045...