Chromium Code Reviews
Help | Chromium Project | Sign in
(234)

Issue 2567813002: cros: DBUS client to interact with fingerprint DBUS API.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by sammiequon
Modified:
1 day, 16 hours ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: DBUS client to interact with fingerprint DBUS API. Skeleton of DBUS client to interact with fingerprint DBUS API. Fake client and rest of methods/properties to come shortly after. Part 1 of a 5 patch series: https://codereview.chromium.org/2567813002/ Adds biometrics manager interface <<< https://codereview.chromium.org/2581403002/ Adds other interfaces https://codereview.chromium.org/2578323004/ Adds fake clients https://codereview.chromium.org/2646793003/ Hook up to chromeos https://codereview.chromium.org/2644233002/ Add a fake implemntation TEST=chromeos_unittest --gtest_filter="BiodBiometricsManagerClientTest.*" BUG=702675

Patch Set 1 #

Patch Set 2 : Updated API and names. #

Patch Set 3 : Some nits. #

Patch Set 4 : Rebased to master. #

Total comments: 4

Patch Set 5 : Fixed patch set 4 errors. #

Total comments: 24

Patch Set 6 : Fixed patch set 5 errors. #

Patch Set 7 : ScanFailed -> SessionFailed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -0 lines) Patch
M chromeos/BUILD.gn View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
A chromeos/dbus/biod_biometrics_manager_client.h View 1 2 3 4 5 6 1 chunk +115 lines, -0 lines 0 comments Download
A chromeos/dbus/biod_biometrics_manager_client.cc View 1 2 3 4 5 6 1 chunk +259 lines, -0 lines 0 comments Download
A chromeos/dbus/biod_biometrics_manager_client_unittest.cc View 1 2 3 4 5 6 1 chunk +328 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 29 (20 generated)
sammiequon
On 2016/12/13 01:40:01, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:steel@chromium.org steel@ - Please ...
3 months, 1 week ago (2016-12-13 01:40:17 UTC) #4
sammiequon
On 2016/12/13 01:40:17, sammiequon wrote: > On 2016/12/13 01:40:01, sammiequon wrote: > > mailto:sammiequon@chromium.org changed ...
1 week, 1 day ago (2017-03-14 19:06:01 UTC) #9
rkc
lgtm % comments https://codereview.chromium.org/2567813002/diff/120001/chromeos/dbus/biod_biometrics_manager_client.cc File chromeos/dbus/biod_biometrics_manager_client.cc (right): https://codereview.chromium.org/2567813002/diff/120001/chromeos/dbus/biod_biometrics_manager_client.cc#newcode274 chromeos/dbus/biod_biometrics_manager_client.cc:274: DBusClientImplementationType type) { Unused? https://codereview.chromium.org/2567813002/diff/120001/chromeos/dbus/biod_biometrics_manager_client_unittest.cc File ...
2 days, 16 hours ago (2017-03-20 23:24:34 UTC) #20
sammiequon
Thanks! https://codereview.chromium.org/2567813002/diff/120001/chromeos/dbus/biod_biometrics_manager_client.cc File chromeos/dbus/biod_biometrics_manager_client.cc (right): https://codereview.chromium.org/2567813002/diff/120001/chromeos/dbus/biod_biometrics_manager_client.cc#newcode274 chromeos/dbus/biod_biometrics_manager_client.cc:274: DBusClientImplementationType type) { On 2017/03/20 23:24:34, rkc wrote: ...
2 days, 16 hours ago (2017-03-21 00:13:36 UTC) #22
sammiequon
stevenjb@ - Please take a look. Thanks!
2 days, 15 hours ago (2017-03-21 01:11:09 UTC) #24
stevenjb
https://codereview.chromium.org/2567813002/diff/140001/chromeos/dbus/biod_biometrics_manager_client.cc File chromeos/dbus/biod_biometrics_manager_client.cc (right): https://codereview.chromium.org/2567813002/diff/140001/chromeos/dbus/biod_biometrics_manager_client.cc#newcode23 chromeos/dbus/biod_biometrics_manager_client.cc:23: : biometrics_manager_proxy_(NULL), weak_ptr_factory_(this) {} s/NULL/nullptr throughout https://codereview.chromium.org/2567813002/diff/140001/chromeos/dbus/biod_biometrics_manager_client.cc#newcode195 chromeos/dbus/biod_biometrics_manager_client.cc:195: void ...
1 day, 21 hours ago (2017-03-21 18:46:17 UTC) #25
sammiequon
https://codereview.chromium.org/2567813002/diff/140001/chromeos/dbus/biod_biometrics_manager_client.cc File chromeos/dbus/biod_biometrics_manager_client.cc (right): https://codereview.chromium.org/2567813002/diff/140001/chromeos/dbus/biod_biometrics_manager_client.cc#newcode23 chromeos/dbus/biod_biometrics_manager_client.cc:23: : biometrics_manager_proxy_(NULL), weak_ptr_factory_(this) {} On 2017/03/21 18:46:16, stevenjb wrote: ...
1 day, 19 hours ago (2017-03-21 20:50:19 UTC) #27
stevenjb
lgtm
1 day, 19 hours ago (2017-03-21 21:12:01 UTC) #28
sammiequon
1 day, 16 hours ago (2017-03-21 23:26:06 UTC) #29
On 2017/03/21 21:12:01, stevenjb wrote:
> lgtm

Thanks!

Changed some naming to match the changes here
https://chromium-review.googlesource.com/c/455465/.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62