cros: Remaining interfaces for DBUS biometrics client.

chromeos/dbus/biod_record_client.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chromeos/dbus/biod_record_client.h"
+
+#include <stdint.h>
+
+#include "base/bind.h"
+#include "base/macros.h"
+#include "dbus/bus.h"
+#include "dbus/message.h"
+#include "dbus/object_path.h"
+#include "dbus/object_proxy.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace chromeos {
+
+// The BiodRecordClient implementation used in production.
+class BiodRecordClientImpl : public BiodRecordClient {
+ public:
+  BiodRecordClientImpl() : weak_ptr_factory_(this) {}
+
+  ~BiodRecordClientImpl() override {}
+
+  void SetRecordLabel(const dbus::ObjectPath& record_path,
+                      const std::string& label) override {
+    dbus::MethodCall method_call(biod::kRecordInterface,
+                                 biod::kRecordSetLabelMethod);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(label);
+
+    dbus::ObjectProxy* record_proxy =
+        bus_->GetObjectProxy(biod::kBiodServiceName, record_path);
+    record_proxy->CallMethod(&method_call,
+                             dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+                             dbus::ObjectProxy::EmptyResponseCallback());
+  }
+
+  void RemoveRecord(const dbus::ObjectPath& record_path) override {
+    dbus::MethodCall method_call(biod::kRecordInterface,
+                                 biod::kRecordRemoveMethod);
+
+    dbus::ObjectProxy* record_proxy =
+        bus_->GetObjectProxy(biod::kBiodServiceName, record_path);
+    record_proxy->CallMethod(&method_call,
+                             dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+                             dbus::ObjectProxy::EmptyResponseCallback());
+  }
+
+  void RequestRecordLabel(const dbus::ObjectPath& record_path,
+                          const LabelCallback& callback) override {
+    dbus::MethodCall method_call(dbus::kDBusPropertiesInterface,
+                                 dbus::kDBusPropertiesGet);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(biod::kRecordInterface);
+    writer.AppendString(biod::kRecordLabelProperty);
+
+    dbus::ObjectProxy* record_proxy =
+        bus_->GetObjectProxy(biod::kBiodServiceName, record_path);
+    record_proxy->CallMethod(
+        &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+        base::Bind(&BiodRecordClientImpl::OnRequestRecordLabel,
+                   weak_ptr_factory_.GetWeakPtr(), callback));
+  }
+
+ protected:
+  void Init(dbus::Bus* bus) override { bus_ = bus; }
+
+ private:
+  void OnRequestRecordLabel(const LabelCallback& callback,
+                            dbus::Response* response) {
+    dbus::MessageReader reader(response);
+    std::string result;
+    if (!response) {
+      LOG(ERROR) << "Error calling " << biod::kRecordLabelProperty;

[stevenjb, 2017/03/23 20:23:34]

Shouldn't we check this before constructing |reader| in line 73? We can call
callback.Run("") and early exit in that case.

[sammiequon, 2017/03/23 21:12:25]

Done.

+    } else if (!reader.PopVariantOfString(&result)) {
+      LOG(ERROR) << "Error reading response from biod: "
+                 << response->ToString();
+    }
+    callback.Run(result);
+  }
+
+  dbus::Bus* bus_;
+
+  // Note: This should remain the last member so it'll be destroyed and
+  // invalidate its weak pointers before any other members are destroyed.
+  base::WeakPtrFactory<BiodRecordClientImpl> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(BiodRecordClientImpl);
+};
+
+BiodRecordClient::BiodRecordClient() {}
+
+BiodRecordClient::~BiodRecordClient() {}
+
+// static
+BiodRecordClient* BiodRecordClient::Create(
+    DBusClientImplementationType /* type */) {
+  return new BiodRecordClientImpl();
+}
+
+}  // namespace chromeos