Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2580793004: service worker: Add CHECKs for investigating null http info bug. (Closed)

Created:
4 years ago by falken
Modified:
4 years ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Add CHECKs for investigating null http info bug. Sheriffs: This patch will likely cause crashes. I'll revert once we gather enough data. BUG=485900 Committed: https://crrev.com/4c7d6c7c1c5323daa31304a094d4353c4b121f8c Cr-Commit-Position: refs/heads/master@{#439412}

Patch Set 1 #

Patch Set 2 : Fix foreign fetch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -30 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M content/browser/service_worker/foreign_fetch_request_handler_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_fetch_dispatcher.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 5 chunks +29 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
falken
ptal
4 years ago (2016-12-16 07:39:40 UTC) #4
nhiroki
lgtm
4 years ago (2016-12-19 03:12:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2580793004/20001
4 years ago (2016-12-19 03:37:34 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-19 05:13:54 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-19 05:16:55 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c7d6c7c1c5323daa31304a094d4353c4b121f8c
Cr-Commit-Position: refs/heads/master@{#439412}

Powered by Google App Engine
This is Rietveld 408576698