Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2580793004: service worker: Add CHECKs for investigating null http info bug. (Closed)
Patch Set: Fix foreign fetch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index c074651cb42c469b58061bf9905ee12c50504dfb..553e01b0cde8a9189d41a024e7a2b8d667a5122c 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -194,8 +194,12 @@ class ServiceWorkerFetchDispatcher::ResponseCallback {
NOTREACHED() << "Should only receive one reply per event";
// |fetch_dispatcher| is null if the URLRequest was killed.
- if (fetch_dispatcher_)
+ if (fetch_dispatcher_) {
+ // TODO(falken): Remove this CHECK once https://crbug.com/485900 is
+ // resolved.
+ CHECK(version_->GetMainScriptHttpResponseInfo());
fetch_dispatcher_->DidFinish(request_id, fetch_result, response);
+ }
}
private:
@@ -294,6 +298,9 @@ void ServiceWorkerFetchDispatcher::DispatchFetchEvent() {
DCHECK_EQ(EmbeddedWorkerStatus::RUNNING, version_->running_status())
<< "Worker stopped too soon after it was started.";
+ // TODO(falken): Remove this CHECK once https://crbug.com/485900 is resolved.
+ CHECK(version_->GetMainScriptHttpResponseInfo());
+
DCHECK(!prepare_callback_.is_null());
base::Closure prepare_callback = prepare_callback_;
prepare_callback.Run();

Powered by Google App Engine
This is Rietveld 408576698