Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 2580793004: service worker: Add CHECKs for investigating null http info bug. (Closed)
Patch Set: Fix foreign fetch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index bf62e063391cbf2b957c0636fe12fa46b4155883..4f3b3bf5ebbb4442ef3ab5607b79e44d9e52b664 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -67,6 +67,7 @@
#include "content/shell/browser/shell_content_browser_client.h"
#include "content/test/test_content_browser_client.h"
#include "net/dns/mock_host_resolver.h"
+#include "net/http/http_response_info.h"
#include "net/log/net_log_with_source.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/embedded_test_server/http_request.h"
@@ -384,6 +385,17 @@ bool CheckHeader(const base::DictionaryValue& dict,
return false;
}
+net::HttpResponseInfo CreateHttpResponseInfo() {
+ net::HttpResponseInfo info;
+ const char data[] =
+ "HTTP/1.1 200 OK\0"
+ "Content-Type: application/javascript\0"
+ "\0";
+ info.headers =
+ new net::HttpResponseHeaders(std::string(data, arraysize(data)));
+ return info;
+}
+
} // namespace
class ServiceWorkerBrowserTest
@@ -694,6 +706,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
void StartOnIOThread(const base::Closure& done,
ServiceWorkerStatusCode* result) {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ version_->SetMainScriptHttpResponseInfo(CreateHttpResponseInfo());
version_->StartWorker(ServiceWorkerMetrics::EventType::UNKNOWN,
CreateReceiver(BrowserThread::UI, done, result));
}
@@ -762,6 +775,7 @@ class ServiceWorkerVersionBrowserTest : public ServiceWorkerBrowserTest {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));
version_->set_fetch_handler_existence(
ServiceWorkerVersion::FetchHandlerExistence::EXISTS);
+ version_->SetMainScriptHttpResponseInfo(CreateHttpResponseInfo());
version_->SetStatus(ServiceWorkerVersion::ACTIVATING);
registration_->SetActiveVersion(version_.get());
version_->RunAfterStartWorker(

Powered by Google App Engine
This is Rietveld 408576698