Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 2580793004: service worker: Add CHECKs for investigating null http info bug. (Closed)
Patch Set: Fix foreign fetch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
index 30021b9d4b4246e941e238d21f36f07ebe74c59d..6e518aea19186ce1c2dc494f809bf2945a466517 100644
--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc
@@ -911,34 +911,6 @@ TEST_P(ServiceWorkerURLRequestJobTestP, FailFetchDispatch) {
EXPECT_FALSE(info->service_worker_ready_time().is_null());
}
-// TODO(horo): Remove this test when crbug.com/485900 is fixed.
-TEST_P(ServiceWorkerURLRequestJobTestP, MainScriptHTTPResponseInfoNotSet) {
- // Shouldn't crash if MainScriptHttpResponseInfo is not set.
- SetUpWithHelper(new EmbeddedWorkerTestHelper(base::FilePath()), false);
- version_->SetStatus(ServiceWorkerVersion::ACTIVATED);
- request_ = url_request_context_.CreateRequest(
- GURL("https://example.com/foo.html"), net::DEFAULT_PRIORITY,
- &url_request_delegate_);
- request_->set_method("GET");
- request_->Start();
- base::RunLoop().RunUntilIdle();
- EXPECT_TRUE(request_->status().is_success());
- EXPECT_EQ(200, request_->GetResponseCode());
- EXPECT_EQ("", url_request_delegate_.response_data());
-
- EXPECT_EQ(0, times_prepare_to_restart_invoked_);
- ServiceWorkerResponseInfo* info =
- ServiceWorkerResponseInfo::ForRequest(request_.get());
- ASSERT_TRUE(info);
- EXPECT_TRUE(info->was_fetched_via_service_worker());
- EXPECT_FALSE(info->was_fallback_required());
- EXPECT_EQ(0u, info->url_list_via_service_worker().size());
- EXPECT_EQ(blink::WebServiceWorkerResponseTypeDefault,
- info->response_type_via_service_worker());
- EXPECT_FALSE(info->service_worker_start_time().is_null());
- EXPECT_FALSE(info->service_worker_ready_time().is_null());
-}
-
TEST_P(ServiceWorkerURLRequestJobTestP, FailToActivate_MainResource) {
RunFailToActivateTest(RESOURCE_TYPE_MAIN_FRAME);

Powered by Google App Engine
This is Rietveld 408576698