Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2579693003: Remove STLDeleteElements. (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
4 years ago
Reviewers:
brettw
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove STLDeleteElements. BUG=555865 Committed: https://crrev.com/1bd8046a2de8913f8fa6bbecfcd386b0029b8ed6 Cr-Commit-Position: refs/heads/master@{#438972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -9 lines 0 comments Download
M base/stl_util.h View 1 chunk +1 line, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Avi (use Gerrit)
PTAL. DeleteValues is almost done too, but I want to get this in first.
4 years ago (2016-12-15 19:54:43 UTC) #4
brettw
lgtm
4 years ago (2016-12-15 22:11:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579693003/1
4 years ago (2016-12-15 22:15:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 00:59:44 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-16 01:02:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bd8046a2de8913f8fa6bbecfcd386b0029b8ed6
Cr-Commit-Position: refs/heads/master@{#438972}

Powered by Google App Engine
This is Rietveld 408576698