Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2574583005: Remove stl_util's deletion function use from message center notifier settings. (Closed)

Created:
4 years ago by Avi (use Gerrit)
Modified:
4 years ago
Reviewers:
dewittj
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion function use from message center notifier settings. BUG=555865 Committed: https://crrev.com/77f2784e3217aba5f8cc05dfff5eebf88a5f1235 Cr-Commit-Position: refs/heads/master@{#438924}

Patch Set 1 #

Patch Set 2 : _ #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -275 lines) Patch
M chrome/browser/notifications/message_center_settings_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/notifications/message_center_settings_controller_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/message_center/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/message_center/fake_notifier_settings_provider.h View 1 chunk +0 lines, -74 lines 0 comments Download
D ui/message_center/fake_notifier_settings_provider.cc View 1 chunk +0 lines, -129 lines 0 comments Download
M ui/message_center/notifier_settings.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 1 2 4 chunks +11 lines, -10 lines 0 comments Download
M ui/message_center/views/notifier_settings_view_unittest.cc View 1 2 6 chunks +67 lines, -43 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
Avi (use Gerrit)
Please take a look. A bit of simplification too, along the way.
4 years ago (2016-12-14 21:05:30 UTC) #10
dewittj
lgtm, thanks! https://codereview.chromium.org/2574583005/diff/20001/ui/message_center/views/notifier_settings_view_unittest.cc File ui/message_center/views/notifier_settings_view_unittest.cc (right): https://codereview.chromium.org/2574583005/diff/20001/ui/message_center/views/notifier_settings_view_unittest.cc#newcode137 ui/message_center/views/notifier_settings_view_unittest.cc:137: for (auto* button : buttons) { can ...
4 years ago (2016-12-15 17:46:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574583005/40001
4 years ago (2016-12-15 19:18:28 UTC) #14
Avi (use Gerrit)
https://codereview.chromium.org/2574583005/diff/20001/ui/message_center/views/notifier_settings_view_unittest.cc File ui/message_center/views/notifier_settings_view_unittest.cc (right): https://codereview.chromium.org/2574583005/diff/20001/ui/message_center/views/notifier_settings_view_unittest.cc#newcode137 ui/message_center/views/notifier_settings_view_unittest.cc:137: for (auto* button : buttons) { On 2016/12/15 17:46:33, ...
4 years ago (2016-12-15 19:23:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 21:08:11 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-15 21:11:47 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/77f2784e3217aba5f8cc05dfff5eebf88a5f1235
Cr-Commit-Position: refs/heads/master@{#438924}

Powered by Google App Engine
This is Rietveld 408576698