Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2579693003: Remove STLDeleteElements. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/stl_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index da46670970c7c4a7bb7c5b42566b0d60a6491044..bdca3d2b6d60102de64585a5de7256beca066a54 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -316,15 +316,6 @@ _BANNED_CPP_FUNCTIONS = (
(),
),
(
- r'STLDeleteElements', # http://crbug.com/555865
- (
- 'This call is obsolete with C++ 11; create a container with owning',
- 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).',
- ),
- True,
- (),
- ),
- (
r'STLDeleteValues', # http://crbug.com/555865
(
'This call is obsolete with C++ 11; create a map with owning',
« no previous file with comments | « no previous file | base/stl_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698