Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: PRESUBMIT.py

Issue 2579693003: Remove STLDeleteElements. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/stl_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
309 ), 309 ),
310 ( 310 (
311 '#pragma comment(lib,', 311 '#pragma comment(lib,',
312 ( 312 (
313 'Specify libraries to link with in build files and not in the source.', 313 'Specify libraries to link with in build files and not in the source.',
314 ), 314 ),
315 True, 315 True,
316 (), 316 (),
317 ), 317 ),
318 ( 318 (
319 r'STLDeleteElements', # http://crbug.com/555865
320 (
321 'This call is obsolete with C++ 11; create a container with owning',
322 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).',
323 ),
324 True,
325 (),
326 ),
327 (
328 r'STLDeleteValues', # http://crbug.com/555865 319 r'STLDeleteValues', # http://crbug.com/555865
329 ( 320 (
330 'This call is obsolete with C++ 11; create a map with owning', 321 'This call is obsolete with C++ 11; create a map with owning',
331 'pointers instead (e.g. std::map<std::string, std::unique_ptr<x>> ).', 322 'pointers instead (e.g. std::map<std::string, std::unique_ptr<x>> ).',
332 ), 323 ),
333 True, 324 True,
334 (), 325 (),
335 ), 326 ),
336 ) 327 )
337 328
(...skipping 1990 matching lines...) Expand 10 before | Expand all | Expand 10 after
2328 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2319 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2329 input_api, 2320 input_api,
2330 output_api, 2321 output_api,
2331 json_url='http://chromium-status.appspot.com/current?format=json')) 2322 json_url='http://chromium-status.appspot.com/current?format=json'))
2332 2323
2333 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2324 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2334 input_api, output_api)) 2325 input_api, output_api))
2335 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2326 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2336 input_api, output_api)) 2327 input_api, output_api))
2337 return results 2328 return results
OLDNEW
« no previous file with comments | « no previous file | base/stl_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698