Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2579663002: Update comments about scrollbar thickness. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update comments about scrollbar thickness. Also, rename LayoutThemeDefault::scrollbarThicknessInDIP to menuListArrowWidthInDIP. Committed: https://crrev.com/eaa097c3feb51366186185cdcbd372cea46f9be5 Cr-Commit-Position: refs/heads/master@{#440158}

Patch Set 1 #

Patch Set 2 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainterDefault.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tkent
keishi@, would you review this please?
4 years ago (2016-12-15 03:08:37 UTC) #5
keishi
LGTM
4 years ago (2016-12-21 10:59:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579663002/20001
4 years ago (2016-12-21 14:35:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-21 18:25:58 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-21 18:29:49 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eaa097c3feb51366186185cdcbd372cea46f9be5
Cr-Commit-Position: refs/heads/master@{#440158}

Powered by Google App Engine
This is Rietveld 408576698