Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

Issue 2579663002: Update comments about scrollbar thickness. (Closed)
Patch Set: _ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of the WebKit project. 2 * This file is part of the WebKit project.
3 * 3 *
4 * Copyright (C) 2006 Apple Computer, Inc. 4 * Copyright (C) 2006 Apple Computer, Inc.
5 * Copyright (C) 2006 Michael Emmel mike.emmel@gmail.com 5 * Copyright (C) 2006 Michael Emmel mike.emmel@gmail.com
6 * Copyright (C) 2007 Holger Hans Peter Freyther 6 * Copyright (C) 2007 Holger Hans Peter Freyther
7 * Copyright (C) 2007 Alp Toker <alp@atoker.com> 7 * Copyright (C) 2007 Alp Toker <alp@atoker.com>
8 * Copyright (C) 2008, 2009 Google, Inc. 8 * Copyright (C) 2008, 2009 Google, Inc.
9 * All rights reserved. 9 * All rights reserved.
10 * Copyright (C) 2009 Kenneth Rohde Christiansen 10 * Copyright (C) 2009 Kenneth Rohde Christiansen
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 double animationRepeatIntervalForProgressBar() const override; 109 double animationRepeatIntervalForProgressBar() const override;
110 double animationDurationForProgressBar() const override; 110 double animationDurationForProgressBar() const override;
111 111
112 // These methods define the padding for the MenuList's inner block. 112 // These methods define the padding for the MenuList's inner block.
113 int popupInternalPaddingStart(const ComputedStyle&) const override; 113 int popupInternalPaddingStart(const ComputedStyle&) const override;
114 int popupInternalPaddingEnd(const HostWindow*, 114 int popupInternalPaddingEnd(const HostWindow*,
115 const ComputedStyle&) const override; 115 const ComputedStyle&) const override;
116 int popupInternalPaddingTop(const ComputedStyle&) const override; 116 int popupInternalPaddingTop(const ComputedStyle&) const override;
117 int popupInternalPaddingBottom(const ComputedStyle&) const override; 117 int popupInternalPaddingBottom(const ComputedStyle&) const override;
118 int scrollbarThicknessInDIP() const; 118 // This returns a value based on scrollbar thickness. It's not 0 even in
119 // overlay scrollbar mode. On Android, this doesn't match to scrollbar
120 // thickness, which is 3px or 4px, and we use the value from the default Aura
121 // theme.
122 int menuListArrowWidthInDIP() const;
119 float clampedMenuListArrowPaddingSize(const HostWindow*, 123 float clampedMenuListArrowPaddingSize(const HostWindow*,
120 const ComputedStyle&) const; 124 const ComputedStyle&) const;
121 125
122 // Provide a way to pass the default font size from the Settings object 126 // Provide a way to pass the default font size from the Settings object
123 // to the layout theme. FIXME: http://b/1129186 A cleaner way would be 127 // to the layout theme. FIXME: http://b/1129186 A cleaner way would be
124 // to remove the default font size from this object and have callers 128 // to remove the default font size from this object and have callers
125 // that need the value to get it directly from the appropriate Settings 129 // that need the value to get it directly from the appropriate Settings
126 // object. 130 // object.
127 static void setDefaultFontSize(int); 131 static void setDefaultFontSize(int);
128 132
(...skipping 19 matching lines...) Expand all
148 152
149 static const RGBA32 defaultTapHighlightColor = 0x2e000000; // 18% black. 153 static const RGBA32 defaultTapHighlightColor = 0x2e000000; // 18% black.
150 static double m_caretBlinkInterval; 154 static double m_caretBlinkInterval;
151 155
152 static unsigned m_activeSelectionBackgroundColor; 156 static unsigned m_activeSelectionBackgroundColor;
153 static unsigned m_activeSelectionForegroundColor; 157 static unsigned m_activeSelectionForegroundColor;
154 static unsigned m_inactiveSelectionBackgroundColor; 158 static unsigned m_inactiveSelectionBackgroundColor;
155 static unsigned m_inactiveSelectionForegroundColor; 159 static unsigned m_inactiveSelectionForegroundColor;
156 160
157 ThemePainterDefault m_painter; 161 ThemePainterDefault m_painter;
158 int m_scrollbarThicknessInDIP = 0; 162 int m_menuListArrowWidthInDIP = 0;
159 }; 163 };
160 164
161 } // namespace blink 165 } // namespace blink
162 166
163 #endif // LayoutThemeDefault_h 167 #endif // LayoutThemeDefault_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698