Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutThemeDefault.h

Issue 2579663002: Update comments about scrollbar thickness. (Closed)
Patch Set: _ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h b/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
index 874733a1ea6cc1ec9afc37539d14fd32fe2f969e..498edfdc2ff9b0fdecf5fdc6676ba18799b2e90e 100644
--- a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
+++ b/third_party/WebKit/Source/core/layout/LayoutThemeDefault.h
@@ -115,7 +115,11 @@ class CORE_EXPORT LayoutThemeDefault : public LayoutTheme {
const ComputedStyle&) const override;
int popupInternalPaddingTop(const ComputedStyle&) const override;
int popupInternalPaddingBottom(const ComputedStyle&) const override;
- int scrollbarThicknessInDIP() const;
+ // This returns a value based on scrollbar thickness. It's not 0 even in
+ // overlay scrollbar mode. On Android, this doesn't match to scrollbar
+ // thickness, which is 3px or 4px, and we use the value from the default Aura
+ // theme.
+ int menuListArrowWidthInDIP() const;
float clampedMenuListArrowPaddingSize(const HostWindow*,
const ComputedStyle&) const;
@@ -155,7 +159,7 @@ class CORE_EXPORT LayoutThemeDefault : public LayoutTheme {
static unsigned m_inactiveSelectionForegroundColor;
ThemePainterDefault m_painter;
- int m_scrollbarThicknessInDIP = 0;
+ int m_menuListArrowWidthInDIP = 0;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698