Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp

Issue 2579663002: Update comments about scrollbar thickness. (Closed)
Patch Set: _ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp b/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
index 39e0c091e08542627ef03e4bab07aeab36fa7192..53356ee8d295a272f6b1537e919adf05b5769f23 100644
--- a/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp
@@ -335,22 +335,22 @@ int LayoutThemeDefault::popupInternalPaddingBottom(
return menuListInternalPadding(style, 1);
}
-int LayoutThemeDefault::scrollbarThicknessInDIP() const {
- if (m_scrollbarThicknessInDIP > 0)
- return m_scrollbarThicknessInDIP;
+int LayoutThemeDefault::menuListArrowWidthInDIP() const {
+ if (m_menuListArrowWidthInDIP > 0)
+ return m_menuListArrowWidthInDIP;
int width = Platform::current()
->themeEngine()
->getSize(WebThemeEngine::PartScrollbarUpArrow)
.width;
- const_cast<LayoutThemeDefault*>(this)->m_scrollbarThicknessInDIP =
+ const_cast<LayoutThemeDefault*>(this)->m_menuListArrowWidthInDIP =
width > 0 ? width : 15;
- return m_scrollbarThicknessInDIP;
+ return m_menuListArrowWidthInDIP;
}
float LayoutThemeDefault::clampedMenuListArrowPaddingSize(
const HostWindow* host,
const ComputedStyle& style) const {
- int originalSize = scrollbarThicknessInDIP();
+ int originalSize = menuListArrowWidthInDIP();
int scaledSize =
host ? host->windowToViewportScalar(originalSize) : originalSize;
// The result should not be samller than the scrollbar thickness in order to

Powered by Google App Engine
This is Rietveld 408576698