Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2578923003: Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. (Closed)

Created:
4 years ago by vasilii
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. The two histograms replace PasswordManager.SignInPromoCountTilClick. It used to record the same number for both buttons. BUG=672163 Committed: https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650 Cr-Commit-Position: refs/heads/master@{#439075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -18 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +17 lines, -10 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc View 5 chunks +12 lines, -6 lines 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_metrics_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
vasilii
Hi Ilya, please review.
4 years ago (2016-12-15 19:11:30 UTC) #4
Ilya Sherman
LGTM, thanks.
4 years ago (2016-12-16 00:40:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578923003/1
4 years ago (2016-12-16 09:19:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 09:25:33 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-16 09:29:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650
Cr-Commit-Position: refs/heads/master@{#439075}

Powered by Google App Engine
This is Rietveld 408576698