Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2578923003: Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <limits> 10 #include <limits>
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 interaction_stats_.update_time = clock_->Now(); 166 interaction_stats_.update_time = clock_->Now();
167 password_manager::PasswordStore* password_store = 167 password_manager::PasswordStore* password_store =
168 PasswordStoreFactory::GetForProfile( 168 PasswordStoreFactory::GetForProfile(
169 profile, ServiceAccessType::IMPLICIT_ACCESS).get(); 169 profile, ServiceAccessType::IMPLICIT_ACCESS).get();
170 password_store->AddSiteStats(interaction_stats_); 170 password_store->AddSiteStats(interaction_stats_);
171 } 171 }
172 } 172 }
173 } 173 }
174 174
175 if (model->state() == password_manager::ui::CHROME_SIGN_IN_PROMO_STATE) { 175 if (model->state() == password_manager::ui::CHROME_SIGN_IN_PROMO_STATE) {
176 metrics_util::LogAutoSigninPromoUserAction(sign_in_promo_dismissal_reason_); 176 metrics_util::LogSyncSigninPromoUserAction(sign_in_promo_dismissal_reason_);
177 if (sign_in_promo_dismissal_reason_ == 177 switch (sign_in_promo_dismissal_reason_) {
178 password_manager::metrics_util::CHROME_SIGNIN_OK || 178 case password_manager::metrics_util::CHROME_SIGNIN_OK:
179 sign_in_promo_dismissal_reason_ == 179 UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilSignIn",
180 password_manager::metrics_util::CHROME_SIGNIN_CANCEL) { 180 sign_in_promo_shown_count);
181 UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilClick", 181 break;
182 sign_in_promo_shown_count); 182 case password_manager::metrics_util::CHROME_SIGNIN_CANCEL:
183 } else { 183 UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilNoThanks",
184 UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoDismissalCount", 184 sign_in_promo_shown_count);
185 sign_in_promo_shown_count); 185 break;
186 case password_manager::metrics_util::CHROME_SIGNIN_DISMISSED:
187 UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoDismissalCount",
188 sign_in_promo_shown_count);
189 break;
190 case password_manager::metrics_util::CHROME_SIGNIN_ACTION_COUNT:
191 NOTREACHED();
192 break;
186 } 193 }
187 } else if (model->state() != 194 } else if (model->state() !=
188 password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) { 195 password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
189 // We have separate metrics for the Update bubble so do not record dismissal 196 // We have separate metrics for the Update bubble so do not record dismissal
190 // reason for it. 197 // reason for it.
191 metrics_util::LogUIDismissalReason(dismissal_reason_); 198 metrics_util::LogUIDismissalReason(dismissal_reason_);
192 } 199 }
193 200
194 if (model->state() == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE || 201 if (model->state() == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE ||
195 model->state() == password_manager::ui::PENDING_PASSWORD_STATE) { 202 model->state() == password_manager::ui::PENDING_PASSWORD_STATE) {
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 return metrics_util::NO_UPDATE_SUBMISSION; 518 return metrics_util::NO_UPDATE_SUBMISSION;
512 } 519 }
513 if (state_ != password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) 520 if (state_ != password_manager::ui::PENDING_PASSWORD_UPDATE_STATE)
514 return metrics_util::NO_UPDATE_SUBMISSION; 521 return metrics_util::NO_UPDATE_SUBMISSION;
515 if (password_overridden_) 522 if (password_overridden_)
516 return update_events[3][behavior]; 523 return update_events[3][behavior];
517 if (ShouldShowMultipleAccountUpdateUI()) 524 if (ShouldShowMultipleAccountUpdateUI())
518 return update_events[2][behavior]; 525 return update_events[2][behavior];
519 return update_events[1][behavior]; 526 return update_events[1][behavior];
520 } 527 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698