Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6317)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 2578923003: Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index 67eee851ec69cce2fd254999c2e19c30b2c11f66..5d5a6b8d59d8f32b7ec697f875f0a1eb846b198c 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -173,16 +173,23 @@ void ManagePasswordsBubbleModel::InteractionKeeper::ReportInteractions(
}
if (model->state() == password_manager::ui::CHROME_SIGN_IN_PROMO_STATE) {
- metrics_util::LogAutoSigninPromoUserAction(sign_in_promo_dismissal_reason_);
- if (sign_in_promo_dismissal_reason_ ==
- password_manager::metrics_util::CHROME_SIGNIN_OK ||
- sign_in_promo_dismissal_reason_ ==
- password_manager::metrics_util::CHROME_SIGNIN_CANCEL) {
- UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilClick",
- sign_in_promo_shown_count);
- } else {
- UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoDismissalCount",
- sign_in_promo_shown_count);
+ metrics_util::LogSyncSigninPromoUserAction(sign_in_promo_dismissal_reason_);
+ switch (sign_in_promo_dismissal_reason_) {
+ case password_manager::metrics_util::CHROME_SIGNIN_OK:
+ UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilSignIn",
+ sign_in_promo_shown_count);
+ break;
+ case password_manager::metrics_util::CHROME_SIGNIN_CANCEL:
+ UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoCountTilNoThanks",
+ sign_in_promo_shown_count);
+ break;
+ case password_manager::metrics_util::CHROME_SIGNIN_DISMISSED:
+ UMA_HISTOGRAM_COUNTS_100("PasswordManager.SignInPromoDismissalCount",
+ sign_in_promo_shown_count);
+ break;
+ case password_manager::metrics_util::CHROME_SIGNIN_ACTION_COUNT:
+ NOTREACHED();
+ break;
}
} else if (model->state() !=
password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698