| Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
|
| diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
|
| index 370731a7ea41f70104b7f9083caf7d1dda339ec0..a2b661fccf00fe08a0cbf477ee09d58d3b777ae9 100644
|
| --- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
|
| +++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc
|
| @@ -48,8 +48,10 @@ using ::testing::_;
|
| namespace {
|
|
|
| const char kFakeGroup[] = "FakeGroup";
|
| -const char kSignInPromoCountTilClickMetric[] =
|
| - "PasswordManager.SignInPromoCountTilClick";
|
| +const char kSignInPromoCountTilNoThanksMetric[] =
|
| + "PasswordManager.SignInPromoCountTilNoThanks";
|
| +const char kSignInPromoCountTilSignInMetric[] =
|
| + "PasswordManager.SignInPromoCountTilSignIn";
|
| const char kSignInPromoDismissalCountMetric[] =
|
| "PasswordManager.SignInPromoDismissalCount";
|
| const char kSignInPromoDismissalReasonMetric[] = "PasswordManager.SignInPromo";
|
| @@ -375,7 +377,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SuppressSignInPromo) {
|
| EXPECT_FALSE(model()->ReplaceToShowSignInPromoIfNeeded());
|
| DestroyModel();
|
| histogram_tester.ExpectTotalCount(kSignInPromoDismissalReasonMetric, 0);
|
| - histogram_tester.ExpectTotalCount(kSignInPromoCountTilClickMetric, 0);
|
| + histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);
|
| + histogram_tester.ExpectTotalCount(kSignInPromoCountTilNoThanksMetric, 0);
|
| histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
|
| }
|
|
|
| @@ -401,7 +404,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoOK) {
|
| histogram_tester.ExpectUniqueSample(
|
| kSignInPromoDismissalReasonMetric,
|
| password_manager::metrics_util::CHROME_SIGNIN_OK, 1);
|
| - histogram_tester.ExpectUniqueSample(kSignInPromoCountTilClickMetric, 1, 1);
|
| + histogram_tester.ExpectUniqueSample(kSignInPromoCountTilSignInMetric, 1, 1);
|
| + histogram_tester.ExpectTotalCount(kSignInPromoCountTilNoThanksMetric, 0);
|
| histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
|
| EXPECT_TRUE(prefs()->GetBoolean(
|
| password_manager::prefs::kWasSignInPasswordPromoClicked));
|
| @@ -428,7 +432,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoCancel) {
|
| histogram_tester.ExpectUniqueSample(
|
| kSignInPromoDismissalReasonMetric,
|
| password_manager::metrics_util::CHROME_SIGNIN_CANCEL, 1);
|
| - histogram_tester.ExpectUniqueSample(kSignInPromoCountTilClickMetric, 1, 1);
|
| + histogram_tester.ExpectUniqueSample(kSignInPromoCountTilNoThanksMetric, 1, 1);
|
| + histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);
|
| histogram_tester.ExpectTotalCount(kSignInPromoDismissalCountMetric, 0);
|
| EXPECT_TRUE(prefs()->GetBoolean(
|
| password_manager::prefs::kWasSignInPasswordPromoClicked));
|
| @@ -454,7 +459,8 @@ TEST_F(ManagePasswordsBubbleModelTest, SignInPromoDismiss) {
|
| histogram_tester.ExpectUniqueSample(
|
| kSignInPromoDismissalReasonMetric,
|
| password_manager::metrics_util::CHROME_SIGNIN_DISMISSED, 1);
|
| - histogram_tester.ExpectTotalCount(kSignInPromoCountTilClickMetric, 0);
|
| + histogram_tester.ExpectTotalCount(kSignInPromoCountTilSignInMetric, 0);
|
| + histogram_tester.ExpectTotalCount(kSignInPromoCountTilNoThanksMetric, 0);
|
| histogram_tester.ExpectUniqueSample(kSignInPromoDismissalCountMetric, 1, 1);
|
| EXPECT_FALSE(prefs()->GetBoolean(
|
| password_manager::prefs::kWasSignInPasswordPromoClicked));
|
|
|