Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 257853002: Update the <canvas> IDLs wrt 'unrestricted' (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 7 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, arv+blink, ojan, dglazkov+blink, Rik, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Update the <canvas> IDLs wrt 'unrestricted' With the basic support for 'unrestricted' from https://codereview.chromium.org/257783003 its possible to turn 'float' into 'unrestricted float' where the spec has the attribute/parameter marked that way. Also apply 'unrestricted' to all the non-standard APIs. When the actual support has landed it should be possible to remove any explicit throwing as well, so mark such locations with FIXMEs. BUG=367648 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172733

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add to fill/strokeText as well. #

Patch Set 3 : And now with the right substitution... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -63 lines) Patch
M Source/core/html/canvas/CanvasPathMethods.idl View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 5 chunks +9 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 2 5 chunks +55 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
Lots of flaky tests ATM, but this Cl should not even modify the generated code... ...
6 years, 8 months ago (2014-04-25 13:54:40 UTC) #1
Justin Novosad
https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode1651 Source/core/html/canvas/CanvasRenderingContext2D.cpp:1651: // FIXME: These exceptions will be thrown by generated ...
6 years, 8 months ago (2014-04-25 14:44:28 UTC) #2
fs
https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode1651 Source/core/html/canvas/CanvasRenderingContext2D.cpp:1651: // FIXME: These exceptions will be thrown by generated ...
6 years, 8 months ago (2014-04-25 15:50:15 UTC) #3
Justin Novosad
On 2014/04/25 15:50:15, fs wrote: > https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp > File Source/core/html/canvas/CanvasRenderingContext2D.cpp (right): > > https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp#newcode1651 > ...
6 years, 8 months ago (2014-04-25 16:30:24 UTC) #4
fs
On 2014/04/25 16:30:24, junov wrote: > On 2014/04/25 15:50:15, fs wrote: > > > https://codereview.chromium.org/257853002/diff/1/Source/core/html/canvas/CanvasRenderingContext2D.cpp ...
6 years, 7 months ago (2014-04-28 07:53:01 UTC) #5
fs
The CQ bit was checked by fs@opera.com
6 years, 7 months ago (2014-04-28 07:53:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/257853002/40001
6 years, 7 months ago (2014-04-28 07:54:00 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 08:29:52 UTC) #8
Message was sent while issue was closed.
Change committed as 172733

Powered by Google App Engine
This is Rietveld 408576698