Basic support for unrestricted types

Basic support for unrestricted types

This allows one to use 'unrestricted float' and 'unrestricted double' in
IDL files: they are distinguished by the frontend (they have different
types), but for now the CG generates the same output.

I'll follow this up with [TypeChecking=Unrestricted], which will do type
checking for float and double, but not unrestricted float or unrestricted
double.

R=haraken
BUG=354298
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172603

[Nils Barth (inactive), 2014-04-25 05:40:14]

Start of support for unrestricted!

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
Source/bindings/scripts/v8_types.py:356: 'float':
'static_cast<float>({v8_value}->NumberValue())',
We should have a toFloat wrapper function, right?
(Can do in followup.)

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
Source/bindings/scripts/v8_types.py:624: 'int': 'v8::Integer::New({isolate},
{cpp_value})',
v8Integer wrapper function? (etc.)

https://codereview.chromium.org/257783003/diff/1/Source/bindings/tests/result...
File Source/bindings/tests/results/V8TestObject.cpp (right):

https://codereview.chromium.org/257783003/diff/1/Source/bindings/tests/result...
Source/bindings/tests/results/V8TestObject.cpp:478: TONATIVE_VOID(double,
cppValue, static_cast<double>(v8Value->NumberValue()));
This is the key line in the test case:
for now it's treated just like a usual double (setter).

[haraken, 2014-04-25 06:16:16]

LGTM.

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
Source/bindings/scripts/v8_types.py:356: 'float':
'static_cast<float>({v8_value}->NumberValue())',
On 2014/04/25 05:40:15, Nils Barth wrote:
> We should have a toFloat wrapper function, right?
> (Can do in followup.)

I'm neutral. If we need to write static_cast<float> in a lot of places, it might
be helpful to have toFloat().

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
Source/bindings/scripts/v8_types.py:624: 'int': 'v8::Integer::New({isolate},
{cpp_value})',
On 2014/04/25 05:40:15, Nils Barth wrote:
> v8Integer wrapper function? (etc.)

This is no :) We don't want to have an unnecessary wrapper for V8 APIs. It won't
at all be helpful to just redirect v8Integer to v8::Integer::New.

(Historically we had v8Integer, but we removed it at some point.)

[Nils Barth (inactive), 2014-04-25 07:16:07]

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
Source/bindings/scripts/v8_types.py:356: 'float':
'static_cast<float>({v8_value}->NumberValue())',
On 2014/04/25 06:16:16, haraken wrote:
> I'm neutral. If we need to write static_cast<float> in a lot of places, it
might
> be helpful to have toFloat().

Nope, this is the only place, so no need!

https://codereview.chromium.org/257783003/diff/1/Source/bindings/scripts/v8_t...
Source/bindings/scripts/v8_types.py:624: 'int': 'v8::Integer::New({isolate},
{cpp_value})',
On 2014/04/25 06:16:16, haraken wrote:
> On 2014/04/25 05:40:15, Nils Barth wrote:
> > v8Integer wrapper function? (etc.)
> 
> This is no :) We don't want to have an unnecessary wrapper for V8 APIs. It
won't
> at all be helpful to just redirect v8Integer to v8::Integer::New.
> 
> (Historically we had v8Integer, but we removed it at some point.)

Got it, thanks!

[Nils Barth (inactive), 2014-04-25 07:16:11]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-04-25 07:16:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/257783003/1

[commit-bot: I haz the power, 2014-04-25 07:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 07:49:58]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[Nils Barth (inactive), 2014-04-25 07:51:43]

The CQ bit was checked by nbarth@chromium.org

[commit-bot: I haz the power, 2014-04-25 07:52:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/257783003/1

[commit-bot: I haz the power, 2014-04-25 08:38:53]

Change committed as 172603