Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2575763002: Rename maybeConvertUnderlyingValue() in CSSInterpolationType subclasses (Closed)

Created:
4 years ago by alancutter (OOO until 2018)
Modified:
4 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename maybeConvertUnderlyingValue() in CSSInterpolationType subclasses This patch renames maybeConvertUnderlyingValue() to maybeConvertStandardPropertyUnderlyingValue() in all CSSInterpolationType subclasses and adds an implementation of maybeConvertUnderlyingValue() to CSSInterpolationType that passes directly though. Additionally the the InterpolationEnvironment& parameter has been replaced with the inner StyleResolverState& as nothing else on the environment was needed by the affected classes This is in preparation to support conversion of underlying values for registered custom properties. There are no behavioural changes made by this patch. BUG=671904 Committed: https://crrev.com/f97d1f749bc2f466f1fe8872a0799c58b875a988 Cr-Commit-Position: refs/heads/master@{#440335}

Patch Set 1 #

Patch Set 2 : Moar rename #

Patch Set 3 : SRS #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -141 lines) Patch
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 1 2 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
alancutter (OOO until 2018)
4 years ago (2016-12-21 23:58:19 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm
4 years ago (2016-12-22 00:09:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575763002/60001
4 years ago (2016-12-22 02:15:24 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/33ecfc3a27115c18dcf4a383e1634ad513d515d0
4 years ago (2016-12-22 04:02:05 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-22 04:04:47 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f97d1f749bc2f466f1fe8872a0799c58b875a988
Cr-Commit-Position: refs/heads/master@{#440335}

Powered by Google App Engine
This is Rietveld 408576698