third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp - Issue 2575763002: Rename maybeConvertUnderlyingValue() in CSSInterpolationType subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

Issue 2575763002: Rename maybeConvertUnderlyingValue() in CSSInterpolationType subclasses (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSPathInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

index ca884dc0c888aba1d37d74fecbf22f1345b2bd78..40b05f755b521e6d77cc70c6f179d3c8e086076a 100644

--- a/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp

@@ -95,11 +95,12 @@ InterpolationValue CSSPathInterpolationType::maybeConvertValue(

toCSSPathValue(value).byteStream());

}

-InterpolationValue CSSPathInterpolationType::maybeConvertUnderlyingValue(

- const InterpolationEnvironment& environment) const {

+InterpolationValue

+CSSPathInterpolationType::maybeConvertStandardPropertyUnderlyingValue(

+ const StyleResolverState& state) const {

DCHECK_EQ(cssProperty(), CSSPropertyD);

return PathInterpolationFunctions::convertValue(

- environment.state().style()->svgStyle().d());

+ state.style()->svgStyle().d());

}

PairwiseInterpolationValue CSSPathInterpolationType::maybeMergeSingles(