third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp - Issue 2575763002: Rename maybeConvertUnderlyingValue() in CSSInterpolationType subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

Issue 2575763002: Rename maybeConvertUnderlyingValue() in CSSInterpolationType subclasses (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.h ('k') | third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

index aeabc41fbe3b6943b1c3b3646e0cf97e4bda46fa..8ec6efcfe4c25315c39966441ea3108b4539d240 100644

--- a/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp

@@ -124,9 +124,10 @@ PairwiseInterpolationValue CSSBasicShapeInterpolationType::maybeMergeSingles(

start.nonInterpolableValue.release());

}

-InterpolationValue CSSBasicShapeInterpolationType::maybeConvertUnderlyingValue(

- const InterpolationEnvironment& environment) const {

- const ComputedStyle& style = *environment.state().style();

+InterpolationValue

+CSSBasicShapeInterpolationType::maybeConvertStandardPropertyUnderlyingValue(

+ const StyleResolverState& state) const {

+ const ComputedStyle& style = *state.style();

return BasicShapeInterpolationFunctions::maybeConvertBasicShape(

BasicShapePropertyFunctions::getBasicShape(cssProperty(), style),

style.effectiveZoom());