Add toString() for paint property node classes

Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/a711a5d7b4589476e0da0477c9b961b72d241eff
Cr-Commit-Position: refs/heads/master@{#438378}

[Xianzhu, 2016-12-13 18:37:24]

Description was changed from

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
==========

to

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-13 18:37:24]

Description was changed from

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Xianzhu, 2016-12-13 18:38:21]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 18:38:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-13 18:40:41]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org, weiliangc@chromium.org

[Xianzhu, 2016-12-13 18:40:41]

PTAL.

weilingc: cc
pdr: blink

[pdr., 2016-12-13 19:07:59]

On 2016/12/13 at 18:40:41, wangxianzhu wrote:
> PTAL.
> 
> weilingc: cc
> pdr: blink

LGTM

[Xianzhu, 2016-12-13 19:36:07]

wangxianzhu@chromium.org changed reviewers:
+ vmpstr@chromium.org

[Xianzhu, 2016-12-13 19:36:08]

+vmpstr ptal cc/output/filter_operations.(h|cc) in case weiliangc is not
available now.

[Xianzhu, 2016-12-13 19:50:59]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 19:52:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-13 21:35:21]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2016-12-13 22:02:24]

lgtm

https://codereview.chromium.org/2574713003/diff/60001/cc/output/filter_operat...
File cc/output/filter_operations_unittest.cc (right):

https://codereview.chromium.org/2574713003/diff/60001/cc/output/filter_operat...
cc/output/filter_operations_unittest.cc:961: filters.ToString();
Compare these to expected string please.

[Xianzhu, 2016-12-13 22:09:14]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-13 22:09:14]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2574713003/#ps80001
(title: "Update test")

[Xianzhu, 2016-12-13 22:09:24]

https://codereview.chromium.org/2574713003/diff/60001/cc/output/filter_operat...
File cc/output/filter_operations_unittest.cc (right):

https://codereview.chromium.org/2574713003/diff/60001/cc/output/filter_operat...
cc/output/filter_operations_unittest.cc:961: filters.ToString();
On 2016/12/13 22:02:24, vmpstr wrote:
> Compare these to expected string please.

Done.

[commit-bot: I haz the power, 2016-12-13 22:10:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:24:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481666954132260,
"parent_rev": "e7c16484a15c79e2bd9457af6acefbab2b7a21b3", "commit_rev":
"0b69d5ba93a8fb594774b0c35e1c3aced23703dc"}

[commit-bot: I haz the power, 2016-12-14 01:24:32]

Description was changed from

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2574713003
==========

[commit-bot: I haz the power, 2016-12-14 01:24:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-14 01:27:40]

Description was changed from

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2574713003
==========

to

==========
Add toString() for paint property node classes

This extracts the common code in PaintPropertyTreePrinter.cpp and
PaintPrinters.cpp.

This provides convenient way to dump paint property nodes in debugging
or DCHECK code. I plan to use this in FindPropertiesNeedingUpdate.

The added code is compiled unconditionally but can be removed by
the linker in production because they are not actually used in
production code.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/a711a5d7b4589476e0da0477c9b961b72d241eff
Cr-Commit-Position: refs/heads/master@{#438378}
==========

[commit-bot: I haz the power, 2016-12-14 01:27:41]

Patchset 5 (id:??) landed as
https://crrev.com/a711a5d7b4589476e0da0477c9b961b72d241eff
Cr-Commit-Position: refs/heads/master@{#438378}