Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2572783004: Dump properties in FindPropertiesNeedingUpdate (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dump properties in FindPropertiesNeedingUpdate This allows us to see more info about the reasons of check failures directly in layout test results. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/b9c3536af01957e43cd247314a2d68a2fa6f4852 Cr-Commit-Position: refs/heads/master@{#438436}

Patch Set 1 #

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h View 1 3 chunks +27 lines, -27 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
Xianzhu
4 years ago (2016-12-13 20:15:51 UTC) #4
pdr.
On 2016/12/13 at 20:15:51, wangxianzhu wrote: > LGTM, much easier to debug!
4 years ago (2016-12-13 21:12:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572783004/20001
4 years ago (2016-12-14 01:33:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-12-14 03:34:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572783004/20001
4 years ago (2016-12-14 04:55:37 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 05:00:50 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-14 05:02:24 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9c3536af01957e43cd247314a2d68a2fa6f4852
Cr-Commit-Position: refs/heads/master@{#438436}

Powered by Google App Engine
This is Rietveld 408576698