Refactor PaintChunkProperties to use PropertyTreeState

Refactor PaintChunkProperties to use PropertyTreeState

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/de314bfb82cdafe6eb2295b66a8d108e080170f0
Cr-Commit-Position: refs/heads/master@{#438437}

[chrishtr, 2016-12-13 18:07:01]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-13 18:08:38]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Refactor PaintChunkProperties to use PropertyTreeState

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-12-13 18:08:42]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 18:09:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-12-13 18:17:12]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2016-12-13 18:17:20]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org, wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-13 18:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-13 18:26:20]

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
(right):

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:42:
return properties;
Nit:

return PaintChunkProperties(propertyTreeState);

or

return PaintChunkProperties(PropertyTreeState(
    TransformPaintPropertyNode::root(), ...));

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
(right):

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp:325:
.get());
Will this cause DCHECK(!m_transform->hasOneRef()) failure because
simpleTransform.propertyTreeState is the only reference to the node?

[pdr., 2016-12-13 18:27:10]

LGTM

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h
(right):

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h:34: //
TODO(pdr): Refactor these to use PropertyTreeState.
Please remove this comment

[commit-bot: I haz the power, 2016-12-13 18:42:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 18:42:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-12-13 21:03:40]

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
(right):

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:42:
return properties;
On 2016/12/13 at 18:26:20, Xianzhu wrote:
> Nit:
> 
> return PaintChunkProperties(propertyTreeState);
> 
> or
> 
> return PaintChunkProperties(PropertyTreeState(
>     TransformPaintPropertyNode::root(), ...));

Done.

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h
(right):

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintChunkProperties.h:34: //
TODO(pdr): Refactor these to use PropertyTreeState.
On 2016/12/13 at 18:27:10, pdr. wrote:
> Please remove this comment

Done.

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp
(right):

https://codereview.chromium.org/2573883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp:325:
.get());
On 2016/12/13 at 18:26:20, Xianzhu wrote:
> Will this cause DCHECK(!m_transform->hasOneRef()) failure because
simpleTransform.propertyTreeState is the only reference to the node?

It did DCHECK. I had to adjust PropertyTreeState.h to make the DCHECKS like
this:

DCHECK(!m_transform || !m_transform->hasOneRef())

to allow for a null state when constructing PaintChunks.

[chrishtr, 2016-12-13 21:03:46]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-13 21:03:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2573883002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-12-13 21:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:36:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-12-14 01:52:14]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-14 01:52:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2573883002/#ps60001
(title: "none")

[commit-bot: I haz the power, 2016-12-14 01:53:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 03:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 03:53:56]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Xianzhu, 2016-12-14 04:59:35]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-14 04:59:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:05:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481691575539620,
"parent_rev": "f2f5f1021f792c47dddfd3caece8a0d8184f3a12", "commit_rev":
"edb364705ce7daa4ced4fdb8dfa91b2135256fa9"}

[commit-bot: I haz the power, 2016-12-14 05:05:33]

Description was changed from

==========
Refactor PaintChunkProperties to use PropertyTreeState

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Refactor PaintChunkProperties to use PropertyTreeState

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2573883002
==========

[commit-bot: I haz the power, 2016-12-14 05:05:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 05:08:10]

Description was changed from

==========
Refactor PaintChunkProperties to use PropertyTreeState

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2573883002
==========

to

==========
Refactor PaintChunkProperties to use PropertyTreeState

BUG=668342
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/de314bfb82cdafe6eb2295b66a8d108e080170f0
Cr-Commit-Position: refs/heads/master@{#438437}
==========

[commit-bot: I haz the power, 2016-12-14 05:08:12]

Patchset 4 (id:??) landed as
https://crrev.com/de314bfb82cdafe6eb2295b66a8d108e080170f0
Cr-Commit-Position: refs/heads/master@{#438437}