Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: third_party/WebKit/Source/core/paint/FramePainter.cpp

Issue 2573883002: Refactor PaintChunkProperties to use PropertyTreeState (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/FramePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/FramePainter.cpp b/third_party/WebKit/Source/core/paint/FramePainter.cpp
index dc25b19ee9d4230bd83e3b011e6e8dbaaf38a45e..d05be3f3feffb4771b9085d8c12d1b4bdf159621 100644
--- a/third_party/WebKit/Source/core/paint/FramePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/FramePainter.cpp
@@ -57,10 +57,7 @@ void FramePainter::paint(GraphicsContext& context,
m_frameView->totalPropertyTreeStateForContents()) {
PaintChunkProperties properties(
context.getPaintController().currentPaintChunkProperties());
- properties.transform = contentsState->transform();
- properties.clip = contentsState->clip();
- properties.effect = contentsState->effect();
- properties.scroll = contentsState->scroll();
+ properties.propertyTreeState = *contentsState;
scopedPaintChunkProperties.emplace(context.getPaintController(),
*frameView().layoutView(),
properties);
@@ -101,13 +98,15 @@ void FramePainter::paint(GraphicsContext& context,
// properties. This prevents the scrollbars from scrolling, for example.
PaintChunkProperties properties(
context.getPaintController().currentPaintChunkProperties());
- properties.transform = m_frameView->preTranslation();
- properties.clip = m_frameView->contentClip()->parent();
- properties.effect = contentsState->effect();
+ properties.propertyTreeState.setTransform(
+ m_frameView->preTranslation());
+ properties.propertyTreeState.setClip(
+ m_frameView->contentClip()->parent());
+ properties.propertyTreeState.setEffect(contentsState->effect());
auto* scrollBarScroll = contentsState->scroll();
if (m_frameView->scroll())
scrollBarScroll = m_frameView->scroll()->parent();
- properties.scroll = scrollBarScroll;
+ properties.propertyTreeState.setScroll(scrollBarScroll);
scopedPaintChunkProperties.emplace(context.getPaintController(),
*frameView().layoutView(),
properties);
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxClipper.cpp ('k') | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698