third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 2573883002: Refactor PaintChunkProperties to use PropertyTreeState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2573883002: Refactor PaintChunkProperties to use PropertyTreeState (Closed)

Patch Set: none Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index e8ee61284e0ece14dca9be84bc30cd6b076d92ab..6e429b009f0f55c32ac38b5fb03ba460e41c82c5 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -786,13 +786,13 @@ void PaintArtifactCompositor::update(

: nullptr);

int transformId = propertyTreeManager.compositorIdForTransformNode(

- paintChunk.properties.transform.get());

+ paintChunk.properties.propertyTreeState.transform());

int scrollId = propertyTreeManager.compositorIdForScrollNode(

- paintChunk.properties.scroll.get());

+ paintChunk.properties.propertyTreeState.scroll());

int clipId = propertyTreeManager.compositorIdForClipNode(

- paintChunk.properties.clip.get());

+ paintChunk.properties.propertyTreeState.clip());

int effectId = propertyTreeManager.switchToEffectNode(

- *paintChunk.properties.effect.get());

+ *paintChunk.properties.propertyTreeState.effect());

propertyTreeManager.updateScrollOffset(layer->id(), scrollId);