Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2571063002: Remove Blink-in-JS (Closed)

Created:
4 years ago by adithyas
Modified:
4 years ago
Reviewers:
haraken, esprehn, jbroman
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, jam, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Blink-in-JS Things removed: - PrivateScriptRunner(.h|.cpp|.js) - PrivateScriptTest* - ImplementedInPrivateScript, OnlyExposedToPrivateScript, NoImplHeader idl attributes - ExposeConfiguration enum in V8DOMConfiguration - PrivateScriptIsolatedWorldId and DOMWrapperWorld::getPrivateScriptIsolatedWorld() - UseCounter::countIfNotPrivateScript and Deprecation::countDeprecationIfNotPrivateScript BUG=673844 Committed: https://crrev.com/7b2c60e1df2e57cec4407b975b998af213f29c50 Cr-Commit-Position: refs/heads/master@{#438432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+772 lines, -3650 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/private_script_unittest.html View 1 chunk +0 lines, -132 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/private_script_unittest-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.md View 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/bindings.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.h View 4 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 chunk +0 lines, -490 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.js View 1 chunk +0 lines, -148 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h View 5 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 6 chunks +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp View 1 chunk +10 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8EventTargetCustom.cpp View 2 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp View 5 chunks +14 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/code_generator_v8.py View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_attributes.py View 14 chunks +4 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_methods.py View 14 chunks +1 line, -52 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_utilities.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl View 7 chunks +7 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.h.tmpl View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl View 4 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 6 chunks +7 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterface3.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterfacePartial.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 15 chunks +106 lines, -246 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 29 chunks +416 lines, -1248 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 3 chunks +31 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 4 chunks +6 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/build/scripts/make_private_script_source.py View 1 chunk +0 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 4 chunks +0 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExceptionCode.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PartialPrivateScriptTest.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PartialPrivateScriptTest.js View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PrivateScriptTest.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PrivateScriptTest.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PrivateScriptTest.idl View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PrivateScriptTest.js View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/WebKit/Source/core/testing/PrivateScriptTestTest.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
adithyas
I think this patch removes all code that was added in for Blink-in-JS, I traced ...
4 years ago (2016-12-14 04:23:15 UTC) #7
haraken
Thanks for working on this. This is a lot of simplification! LGTM.
4 years ago (2016-12-14 04:30:04 UTC) #8
esprehn
lgtm, if it lands lets go for it! Otherwise we might need to break this ...
4 years ago (2016-12-14 04:34:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571063002/1
4 years ago (2016-12-14 04:34:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 04:41:08 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-14 04:43:28 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b2c60e1df2e57cec4407b975b998af213f29c50
Cr-Commit-Position: refs/heads/master@{#438432}

Powered by Google App Engine
This is Rietveld 408576698