Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 2571063002: Remove Blink-in-JS (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
index e63777e3ec9da0cadeff6cb14fd31b6e48f351f4..df3a8afc2d34d0ad1fbe7ce9325d69378f5908aa 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
@@ -69,9 +69,7 @@ static v8::Local<v8::Value> getItem(
v8::Local<v8::Uint32> index;
if (!argument->ToArrayIndex(info.GetIsolate()->GetCurrentContext())
.ToLocal(&index)) {
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- namedFeature);
+ UseCounter::count(currentExecutionContext(info.GetIsolate()), namedFeature);
TOSTRING_DEFAULT(V8StringResource<>, name, argument,
v8::Undefined(info.GetIsolate()));
v8::Local<v8::Value> result = getNamedItems(collection, name, info);
@@ -82,14 +80,11 @@ static v8::Local<v8::Value> getItem(
return result;
}
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- indexedFeature);
- if (!argument->IsNumber())
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- indexedWithNonNumberFeature);
-
+ UseCounter::count(currentExecutionContext(info.GetIsolate()), indexedFeature);
+ if (!argument->IsNumber()) {
+ UseCounter::count(currentExecutionContext(info.GetIsolate()),
+ indexedWithNonNumberFeature);
+ }
Element* result = collection->item(index->Value());
return toV8(result, info.Holder(), info.GetIsolate());
}
@@ -97,9 +92,8 @@ static v8::Local<v8::Value> getItem(
void V8HTMLAllCollection::itemMethodCustom(
const v8::FunctionCallbackInfo<v8::Value>& info) {
if (info.Length() < 1) {
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- UseCounter::DocumentAllItemNoArguments);
+ UseCounter::count(currentExecutionContext(info.GetIsolate()),
+ UseCounter::DocumentAllItemNoArguments);
return;
}
@@ -113,15 +107,13 @@ void V8HTMLAllCollection::itemMethodCustom(
void V8HTMLAllCollection::legacyCallCustom(
const v8::FunctionCallbackInfo<v8::Value>& info) {
if (info.Length() < 1) {
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- UseCounter::DocumentAllLegacyCallNoArguments);
+ UseCounter::count(currentExecutionContext(info.GetIsolate()),
+ UseCounter::DocumentAllLegacyCallNoArguments);
return;
}
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- UseCounter::DocumentAllLegacyCall);
+ UseCounter::count(currentExecutionContext(info.GetIsolate()),
+ UseCounter::DocumentAllLegacyCall);
HTMLAllCollection* impl = V8HTMLAllCollection::toImpl(info.Holder());
@@ -134,9 +126,8 @@ void V8HTMLAllCollection::legacyCallCustom(
return;
}
- UseCounter::countIfNotPrivateScript(
- info.GetIsolate(), currentExecutionContext(info.GetIsolate()),
- UseCounter::DocumentAllLegacyCallTwoArguments);
+ UseCounter::count(currentExecutionContext(info.GetIsolate()),
+ UseCounter::DocumentAllLegacyCallTwoArguments);
// If there is a second argument it is the index of the item we want.
TOSTRING_VOID(V8StringResource<>, name, info[0]);

Powered by Google App Engine
This is Rietveld 408576698