Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2571063002: Remove Blink-in-JS (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index 936efada5708f3718afb68ff3765cec3ce639de9..20f8c1094b240b16c3b5eb3b13ccb5dd983a7c8c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -162,19 +162,7 @@ void V8Initializer::messageHandlerInMainThread(v8::Local<v8::Message> message,
}
}
- if (scriptState->world().isPrivateScriptIsolatedWorld()) {
- // We allow a private script to dispatch error events even in a
- // EventDispatchForbiddenScope scope. Without having this ability, it's
- // hard to debug the private script because syntax errors in the private
- // script are not reported to console (the private script just crashes
- // silently). Allowing error events in private scripts is safe because
- // error events don't propagate to other isolated worlds (which means that
- // the error events won't fire any event listeners in user's scripts).
- EventDispatchForbiddenScope::AllowUserAgentEvents allowUserAgentEvents;
- context->dispatchErrorEvent(event, accessControlStatus);
- } else {
- context->dispatchErrorEvent(event, accessControlStatus);
- }
+ context->dispatchErrorEvent(event, accessControlStatus);
}
namespace {

Powered by Google App Engine
This is Rietveld 408576698