Rename documentState() to getDocumentState().

Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org

Committed: https://crrev.com/de6c362bda983c827405e0582564bd219a13121c
Cr-Commit-Position: refs/heads/master@{#437995}

[Łukasz Anforowicz, 2016-12-12 22:14:37]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 22:15:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-12-12 22:20:37]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-12 22:20:38]

dcheng@, could you PTAL?

[dcheng, 2016-12-13 00:45:54]

lgtm

[Łukasz Anforowicz, 2016-12-13 00:48:16]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-12-13 00:48:20]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:48:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:01:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2016-12-13 01:04:52]

Description was changed from

==========
Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
==========

to

==========
Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org
==========

[Łukasz Anforowicz, 2016-12-13 01:06:36]

lukasza@chromium.org changed reviewers:
+ creis@chromium.org

[Łukasz Anforowicz, 2016-12-13 01:06:36]

creis@, I hope you don't mind me TBR-ing you on this CL (the changes in
content/renderer/history_serialization.cc are a mechanical consequence of the
overall rename done by this CL).

[Łukasz Anforowicz, 2016-12-13 01:06:45]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-13 01:07:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:40:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481591205383910, "parent_rev":
"1fa7318db4aee10bd434e333bcd205d35fd344a3", "commit_rev":
"352dc798bdfe128ed73662e3e8423dad1f82e0c0"}

[commit-bot: I haz the power, 2016-12-13 02:40:46]

Description was changed from

==========
Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org
==========

to

==========
Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2569883002
==========

[commit-bot: I haz the power, 2016-12-13 02:40:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 02:42:51]

Description was changed from

==========
Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org

Review-Url: https://codereview.chromium.org/2569883002
==========

to

==========
Rename documentState() to getDocumentState().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |DocumentState|
type and a |documentState| accessor method (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |DocumentState| being the name of both the
type and the accessor method (with both living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=creis@chromium.org

Committed: https://crrev.com/de6c362bda983c827405e0582564bd219a13121c
Cr-Commit-Position: refs/heads/master@{#437995}
==========

[commit-bot: I haz the power, 2016-12-13 02:42:51]

Patchset 1 (id:??) landed as
https://crrev.com/de6c362bda983c827405e0582564bd219a13121c
Cr-Commit-Position: refs/heads/master@{#437995}

[Charlie Reis, 2016-12-13 17:57:37]

Sure, content/ LGTM