Remove widget offscreen code.

Remove widget offscreen code.

The Offscreen state was never set, removed.

Review-Url: https://codereview.chromium.org/2569663006
Committed: https://pdfium.googlesource.com/pdfium/+/68034894d246f1352e7ff221f52c469e008fbfe8

[dsinclair, 2016-12-14 17:01:42]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-14 17:01:42]

PTAL.

[Tom Sepez, 2016-12-14 17:35:26]

https://codereview.chromium.org/2569663006/diff/1/xfa/fwl/cfwl_widget.cpp
File xfa/fwl/cfwl_widget.cpp (left):

https://codereview.chromium.org/2569663006/diff/1/xfa/fwl/cfwl_widget.cpp#old...
xfa/fwl/cfwl_widget.cpp:85: if (IsChild())
did you mean to remove this?  The CL description doesn't mention it if you did,
optherwise ...

[dsinclair, 2016-12-14 17:38:51]

https://codereview.chromium.org/2569663006/diff/1/xfa/fwl/cfwl_widget.cpp
File xfa/fwl/cfwl_widget.cpp (left):

https://codereview.chromium.org/2569663006/diff/1/xfa/fwl/cfwl_widget.cpp#old...
xfa/fwl/cfwl_widget.cpp:85: if (IsChild())
On 2016/12/14 17:35:26, Tom Sepez wrote:
> did you mean to remove this?  The CL description doesn't mention it if you
did,
> optherwise ...


SetWidgetRect_Native is removed because it only works for offscreen code. So,
this early exit isn't needed anymore.

[dsinclair, 2016-12-15 13:59:49]

ping

[dsinclair, 2016-12-15 15:00:47]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 15:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 15:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 15:13:29]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-15 17:48:33]

lgtm

[dsinclair, 2016-12-15 21:44:15]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 21:44:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481838255583880,
"parent_rev": "46a4bbf46723cd6375042d599d01fe08012eadd6", "commit_rev":
"68034894d246f1352e7ff221f52c469e008fbfe8"}

[commit-bot: I haz the power, 2016-12-15 21:44:35]

Description was changed from

==========
Remove widget offscreen code.

The Offscreen state was never set, removed.
==========

to

==========
Remove widget offscreen code.

The Offscreen state was never set, removed.

Review-Url: https://codereview.chromium.org/2569663006
Committed:
https://pdfium.googlesource.com/pdfium/+/68034894d246f1352e7ff221f52c469e008f...
==========

[commit-bot: I haz the power, 2016-12-15 21:44:36]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/68034894d246f1352e7ff221f52c469e008f...