Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2575093002: Cleanup widget edge related code (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup widget edge related code CFWL_Widget::HasEdge() always returns false. This CL removes it and the supporting code. Review-Url: https://codereview.chromium.org/2575093002 Committed: https://pdfium.googlesource.com/pdfium/+/46a4bbf46723cd6375042d599d01fe08012eadd6

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -134 lines) Patch
M xfa/fwl/cfwl_checkbox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_combobox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_datetimepicker.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_edit.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_listbox.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_monthcalendar.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_picturebox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_pushbutton.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/cfwl_scrollbar.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fwl/cfwl_spinbutton.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M xfa/fwl/cfwl_themepart.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/cfwl_widget.h View 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/fwl/cfwl_widget.cpp View 6 chunks +1 line, -34 lines 0 comments Download
M xfa/fwl/theme/cfwl_barcodetp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_comboboxtp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_datetimepickertp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_edittp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_listboxtp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_monthcalendartp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_pictureboxtp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_pushbuttontp.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 1 chunk +0 lines, -4 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.cpp View 1 chunk +0 lines, -25 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dsinclair
PTAL.
4 years ago (2016-12-14 16:51:30 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-14 17:33:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575093002/60001
4 years ago (2016-12-15 21:43:47 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 21:44:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/46a4bbf46723cd6375042d599d01fe08012e...

Powered by Google App Engine
This is Rietveld 408576698