Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2570273003: Remove unused Group widget state (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused Group widget state DO NOT COMMIT This state is not used, remove.

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M xfa/fwl/cfwl_checkbox.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M xfa/fwl/cfwl_widgetmgr.cpp View 2 chunks +1 line, -9 lines 0 comments Download
M xfa/fwl/fwl_widgetdef.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (5 generated)
dsinclair
PTAL. Not sure what to do with this one. The code doesn't make sense if ...
4 years ago (2016-12-14 17:09:03 UTC) #2
Tom Sepez
4 years ago (2016-12-15 17:47:53 UTC) #7
On 2016/12/14 17:09:03, dsinclair wrote:
> PTAL.
> 
> Not sure what to do with this one. The code doesn't make sense if _Group isn't
> used, but _Group, currently, isn't used.
> 
> Should we leave it and try to figure out how it gets set, or remove it and
> patchup the calling code?

I'd leave it for the moment.  Lotta disruptions lately, might be good to see if
any other embedders hit issues after pulling head branch.

Powered by Google App Engine
This is Rietveld 408576698