Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2573163002: Move window type mask up with masked flags (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move window type mask up with masked flags Move code to make clear what is being masked. Review-Url: https://codereview.chromium.org/2573163002 Committed: https://pdfium.googlesource.com/pdfium/+/b04b96b1ea3ef88385bbf736b2bccab7ed12c486

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M xfa/fwl/fwl_widgetdef.h View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
dsinclair
PTAL.
4 years ago (2016-12-15 03:43:52 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-15 17:46:46 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2569663006 Patch 60001). Please resolve the dependency and ...
4 years ago (2016-12-15 17:46:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573163002/40001
4 years ago (2016-12-15 21:44:53 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-15 21:51:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b04b96b1ea3ef88385bbf736b2bccab7ed12...

Powered by Google App Engine
This is Rietveld 408576698