Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names. (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In "pylint: disable=" comments in webkitpy, use symbolic names. Reason: Using symbolic names helps to make it clear what is disabled. BUG=643937 Committed: https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4 Cr-Commit-Position: refs/heads/master@{#438664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -23 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/multiprocessing_bootstrap.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py View 5 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
qyearsley
4 years ago (2016-12-14 19:11:33 UTC) #2
jeffcarp
lgtm
4 years ago (2016-12-14 20:15:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2569153003/1
4 years ago (2016-12-14 22:10:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 23:11:07 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 23:12:49 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73a975e6c1a54bdd9304df38b85fdd9669f478a4
Cr-Commit-Position: refs/heads/master@{#438664}

Powered by Google App Engine
This is Rietveld 408576698