third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py - Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

index 0ac9b69a41bbe6d790439ee4587c9d20e6caab41..2608f57c7919b2a2f73fac609abc607b32415e92 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py

@@ -56,7 +56,7 @@ class BrowserTestPortOverrides(object):

"""Overridden function from the base port class. Redirects everything

to src/chrome/test/data/printing/layout_tests.

"""

- return self.path_from_chromium_base('chrome', 'test', 'data', 'printing', 'layout_tests') # pylint: disable=E1101

+ return self.path_from_chromium_base('chrome', 'test', 'data', 'printing', 'layout_tests') # pylint: disable=no-member

def check_sys_deps(self, needs_http):

"""This function is meant to be a no-op since we don't want to actually

@@ -69,7 +69,7 @@ class BrowserTestPortOverrides(object):

def default_timeout_ms(self):

timeout_ms = 10 * 1000

- if self.get_option('configuration') == 'Debug': # pylint: disable=E1101

+ if self.get_option('configuration') == 'Debug': # pylint: disable=no-member

# Debug is usually 2x-3x slower than Release.

return 3 * timeout_ms

return timeout_ms

@@ -89,7 +89,7 @@ class BrowserTestMacPort(BrowserTestPortOverrides, mac.MacPort):

def default_timeout_ms(self):

timeout_ms = 20 * 1000

- if self.get_option('configuration') == 'Debug': # pylint: disable=E1101

+ if self.get_option('configuration') == 'Debug': # pylint: disable=no-member

# Debug is usually 2x-3x slower than Release.

return 3 * timeout_ms

return timeout_ms

@@ -99,7 +99,7 @@ class BrowserTestWinPort(BrowserTestPortOverrides, win.WinPort):

def default_timeout_ms(self):

timeout_ms = 20 * 1000

- if self.get_option('configuration') == 'Debug': # pylint: disable=E1101

+ if self.get_option('configuration') == 'Debug': # pylint: disable=no-member

# Debug is usually 2x-3x slower than Release.

return 3 * timeout_ms

return timeout_ms