third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py - Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py

Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py

index 91adde1cfbf064ffe73a340b3c031b08d44a0f63..7da1460cf381a0c80277060fb01a2771f2ff4b57 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/abstract_local_server_command.py

@@ -54,5 +54,5 @@ class AbstractLocalServerCommand(Command):

# FIXME: This seems racy.

threading.Timer(0.1, lambda: tool.user.open_url(server_url)).start()

- httpd = self.server(httpd_port=options.httpd_port, config=config) # pylint: disable=E1102

+ httpd = self.server(httpd_port=options.httpd_port, config=config) # pylint: disable=not-callable

httpd.serve_forever()