third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py - Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

Issue 2569153003: In "pylint: disable=" comments in webkitpy, use symbolic names. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

index 30e2a5a8bc3e6bd23b60267b1ab07235d183fb11..5cbd3e198ecd5d016a0ab2a07d2189252c730a10 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py

@@ -310,7 +310,7 @@ class PortTestCase(unittest.TestCase):

port.host.filesystem.write_text_file('/tmp/foo', 'foo')

port.host.filesystem.write_text_file('/tmp/bar', 'bar')

ordered_dict = port.expectations_dict()

- self.assertEqual(ordered_dict.keys()[-2:], options.additional_expectations) # pylint: disable=E1101

+ self.assertEqual(ordered_dict.keys()[-2:], options.additional_expectations)

self.assertEqual(ordered_dict.values()[-2:], ['foo', 'bar'])

def test_path_to_apache_config_file(self):