Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme… (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonElement. Using identical ID for different Element subclasses is dangerous. This CL avoids a runtime CHECK failure. BUG=669847 Committed: https://crrev.com/b998a64a0f1a925cfae371a52562ee5b7c9b4c17 Cr-Commit-Position: refs/heads/master@{#437516}

Patch Set 1 #

Total comments: 4

Patch Set 2 : step_func_done #

Messages

Total messages: 17 (11 generated)
tkent
kochi-san, would you review this please? This is a short-term fix for crbug.com/669847, caused by ...
4 years ago (2016-12-09 07:26:45 UTC) #7
kochi
lgtm https://codereview.chromium.org/2568443002/diff/1/third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html File third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html (right): https://codereview.chromium.org/2568443002/diff/1/third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html#newcode2 third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html:2: <body> Just curious: is this <body> (and L18) ...
4 years ago (2016-12-09 09:07:17 UTC) #8
tkent
https://codereview.chromium.org/2568443002/diff/1/third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html File third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html (right): https://codereview.chromium.org/2568443002/diff/1/third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html#newcode2 third_party/WebKit/LayoutTests/fast/forms/search/search-type-change-crash.html:2: <body> On 2016/12/09 at 09:07:17, kochi wrote: > Just ...
4 years ago (2016-12-09 09:16:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2568443002/20001
4 years ago (2016-12-09 09:16:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 11:03:47 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-09 11:07:52 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b998a64a0f1a925cfae371a52562ee5b7c9b4c17
Cr-Commit-Position: refs/heads/master@{#437516}

Powered by Google App Engine
This is Rietveld 408576698