third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp - Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp

Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme… (Closed)

Patch Set: step_func_done Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp b/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp

index 11f274a15ec74db5622e9d1700ae7e4829211f19..dce8a418553f547b1bcca548ac392e2e4d96b153 100644

--- a/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/TextControlInnerElements.cpp

@@ -165,7 +165,7 @@ SearchFieldCancelButtonElement* SearchFieldCancelButtonElement::create(

SearchFieldCancelButtonElement* element =

new SearchFieldCancelButtonElement(document);

element->setShadowPseudoId(AtomicString("-webkit-search-cancel-button"));

- element->setAttribute(idAttr, ShadowElementNames::clearButton());

+ element->setAttribute(idAttr, ShadowElementNames::searchClearButton());

return element;

}

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/ShadowElementNames.cpp ('k') | no next file » | no next file with comments »