third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp - Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme… (Closed)

Patch Set: step_func_done Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

index df0366dc22eec021b0f59f13a05ac12e95dd7c73..425102b6e6035abc595d8e04213a1e844d20f7f0 100644

--- a/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp

@@ -708,6 +708,9 @@ bool DateTimeEditElement::isReadOnly() const {

void DateTimeEditElement::layout(const LayoutParameters& layoutParameters,

const DateComponents& dateValue) {

+ // TODO(tkent): We assume this function never dispatches events. However this

+ // can dispatch 'blur' event in Node::removeChild().

DEFINE_STATIC_LOCAL(AtomicString, fieldsWrapperPseudoId,

("-webkit-datetime-edit-fields-wrapper"));

if (!hasChildren()) {