third_party/WebKit/Source/core/html/forms/SearchInputType.cpp - Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

Issue 2568443002: INPUT element: Do not use identical ID name for SearchFieldCancelButtonElement and ClearButtonEleme… (Closed)

Patch Set: step_func_done Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp b/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

index a12c860c854417bf1cb56d053fafaef99be49b3c..dda850dc2fa0d96f9f3ec5f1ddcc1c497839279a 100644

--- a/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp

@@ -150,7 +150,7 @@ const AtomicString& SearchInputType::defaultAutocapitalize() const {

void SearchInputType::updateCancelButtonVisibility() {

Element* button = element().userAgentShadowRoot()->getElementById(

- ShadowElementNames::clearButton());

+ ShadowElementNames::searchClearButton());

if (!button)

return;

if (element().value().isEmpty()) {