[inspector] add scope type for modules.

[inspector] add scope type for modules.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5530
Review-Url: https://codereview.chromium.org/2568083002
Cr-Commit-Position: refs/heads/master@{#41765}
Committed: https://chromium.googlesource.com/v8/v8/+/bcb73f6219b6bc119a3658035ef1d1241f9edbf4

[Yang, 2016-12-12 11:58:09]

On 2016/12/12 11:57:24, Yang wrote:

I did not add a test case to test/inspector because the test harness would have
to be extended to be able to load modules, which d8 already can.

[jgruber, 2016-12-12 13:23:48]

lgtm with nits.

https://codereview.chromium.org/2568083002/diff/1/src/inspector/debugger-scri...
File src/inspector/debugger-script.js (right):

https://codereview.chromium.org/2568083002/diff/1/src/inspector/debugger-scri...
src/inspector/debugger-script.js:571: // Also drop empty Block, Eval and Script
scopes, should we get any.
Nit: Update comment.

https://codereview.chromium.org/2568083002/diff/1/src/inspector/debugger_scri...
File src/inspector/debugger_script_externs.js (right):

https://codereview.chromium.org/2568083002/diff/1/src/inspector/debugger_scri...
src/inspector/debugger_script_externs.js:203: Module: 8};
Nit: Whitespace before bracket.

https://codereview.chromium.org/2568083002/diff/1/test/debugger/debug/harmony...
File test/debugger/debug/harmony/modules-debug-scopes1.js (right):

https://codereview.chromium.org/2568083002/diff/1/test/debugger/debug/harmony...
test/debugger/debug/harmony/modules-debug-scopes1.js:8: // These tests are
copied from mjsunit/debug-scopes.js and adapted for modules.
Nit: mjsunit -> debugger/

[dgozman, 2016-12-12 23:22:17]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-12-12 23:22:18]

https://codereview.chromium.org/2568083002/diff/1/src/inspector/js_protocol.json
File src/inspector/js_protocol.json (right):

https://codereview.chromium.org/2568083002/diff/1/src/inspector/js_protocol.j...
src/inspector/js_protocol.json:456: { "name": "type", "type": "string", "enum":
["global", "local", "with", "closure", "catch", "block", "script", "eval",
"module"], "description": "Scope type." },
Module is similar to global, correct?
This patch needs some preparation on front-end side in advance (we check for
scope type in quite a few places).

[kozy, 2016-12-12 23:50:26]

lgtm,
It looks like our frontend is ready for unknown type name [1]. I think we can
add support for new type after this CL is landed otherwise closure compiler will
complai about unknown enum value.

[1]
https://cs.chromium.org/search/?q=Protocol.Debugger.ScopeType+-f:out&sq=packa...

[dgozman, 2016-12-12 23:52:50]

On 2016/12/12 23:50:26, kozyatinskiy wrote:
> lgtm,
> It looks like our frontend is ready for unknown type name [1]. I think we can
> add support for new type after this CL is landed otherwise closure compiler
will
> complai about unknown enum value.
> 
> [1]
>
https://cs.chromium.org/search/?q=Protocol.Debugger.ScopeType+-f:out&sq=packa...

inspector lgtm

[Yang, 2016-12-16 13:58:07]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:58:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 14:28:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481896687384700, "parent_rev":
"16fe4263200532191c4633a96714cec7b6e23510", "commit_rev":
"bcb73f6219b6bc119a3658035ef1d1241f9edbf4"}

[commit-bot: I haz the power, 2016-12-16 14:29:00]

Description was changed from

==========
[inspector] add scope type for modules.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5530
==========

to

==========
[inspector] add scope type for modules.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5530

Review-Url: https://codereview.chromium.org/2568083002
Cr-Commit-Position: refs/heads/master@{#41765}
Committed:
https://chromium.googlesource.com/v8/v8/+/bcb73f6219b6bc119a3658035ef1d1241f9...
==========

[commit-bot: I haz the power, 2016-12-16 14:29:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bcb73f6219b6bc119a3658035ef1d1241f9...