Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: src/inspector/debugger-script.js

Issue 2568083002: [inspector] add scope type for modules. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/debugger_script_externs.js » ('j') | src/inspector/debugger_script_externs.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/debugger-script.js
diff --git a/src/inspector/debugger-script.js b/src/inspector/debugger-script.js
index 766964df236ab15e9c65c2f1b4fccc2a2d264fee..fa3ff4ca5635eb1015db58a0e8201fbd127ac8b2 100644
--- a/src/inspector/debugger-script.js
+++ b/src/inspector/debugger-script.js
@@ -43,6 +43,7 @@ DebuggerScript._scopeTypeNames.set(ScopeType.Catch, "catch");
DebuggerScript._scopeTypeNames.set(ScopeType.Block, "block");
DebuggerScript._scopeTypeNames.set(ScopeType.Script, "script");
DebuggerScript._scopeTypeNames.set(ScopeType.Eval, "eval");
+DebuggerScript._scopeTypeNames.set(ScopeType.Module, "module");
/**
* @param {function()} fun
@@ -560,6 +561,7 @@ DebuggerScript._buildScopeObject = function(scopeType, scopeObject)
case ScopeType.Block:
case ScopeType.Script:
case ScopeType.Eval:
+ case ScopeType.Module:
// For transient objects we create a "persistent" copy that contains
// the same properties.
// Reset scope object prototype to null so that the proto properties
@@ -569,7 +571,8 @@ DebuggerScript._buildScopeObject = function(scopeType, scopeObject)
// Also drop empty Block, Eval and Script scopes, should we get any.
jgruber 2016/12/12 13:23:48 Nit: Update comment.
if (!properties.length && (scopeType === ScopeType.Script ||
scopeType === ScopeType.Block ||
- scopeType === ScopeType.Eval)) {
+ scopeType === ScopeType.Eval ||
+ scopeType === ScopeType.Module)) {
break;
}
result = { __proto__: null };
« no previous file with comments | « no previous file | src/inspector/debugger_script_externs.js » ('j') | src/inspector/debugger_script_externs.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698