Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: test/debugger/debug/harmony/modules-debug-scopes1.js

Issue 2568083002: [inspector] add scope type for modules. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/debugger/debug/harmony/modules-debug-scopes1.js
diff --git a/test/mjsunit/modules-debug-scopes1.js b/test/debugger/debug/harmony/modules-debug-scopes1.js
similarity index 97%
rename from test/mjsunit/modules-debug-scopes1.js
rename to test/debugger/debug/harmony/modules-debug-scopes1.js
index fd094e36a2ba62a6e6be746d8dca8106d90189f3..e67c42de61d1a8d78d220069f2ba91d3726d36bb 100644
--- a/test/mjsunit/modules-debug-scopes1.js
+++ b/test/debugger/debug/harmony/modules-debug-scopes1.js
@@ -3,7 +3,7 @@
// found in the LICENSE file.
// MODULE
-// Flags: --expose-debug-as debug --allow-natives-syntax --noanalyze-environment-liveness
+// Flags: --allow-natives-syntax --noanalyze-environment-liveness
// These tests are copied from mjsunit/debug-scopes.js and adapted for modules.
jgruber 2016/12/12 13:23:48 Nit: mjsunit -> debugger/
@@ -70,7 +70,6 @@ function CheckFastAllScopes(scopes, exec_state)
assertTrue(scopes.length >= length);
for (var i = 0; i < scopes.length && i < length; i++) {
var scope = fast_all_scopes[length - i - 1];
- assertTrue(scope.isScope());
assertEquals(scopes[scopes.length - i - 1], scope.scopeType());
}
}
@@ -84,7 +83,6 @@ function CheckScopeChain(scopes, exec_state) {
"FrameMirror.allScopes length");
for (var i = 0; i < scopes.length; i++) {
var scope = exec_state.frame().scope(i);
- assertTrue(scope.isScope());
assertEquals(scopes[i], scope.scopeType());
assertScopeMirrorEquals(all_scopes[i], scope);
}
@@ -98,7 +96,6 @@ function CheckScopeChainNames(names, exec_state) {
assertEquals(names.length, all_scopes.length, "FrameMirror.allScopes length");
for (var i = 0; i < names.length; i++) {
var scope = exec_state.frame().scope(i);
- assertTrue(scope.isScope());
assertEquals(names[i], scope.details().name())
}
}
@@ -113,12 +110,8 @@ function CheckScopeContent(minimum_content, number, exec_state) {
var property_mirror = scope.scopeObject().property(p);
assertFalse(property_mirror.isUndefined(),
'property ' + p + ' not found in scope');
- if (typeof(minimum_content[p]) === 'function') {
- assertTrue(property_mirror.value().isFunction());
- } else {
- assertEquals(minimum_content[p], property_mirror.value().value(),
- 'property ' + p + ' has unexpected value');
- }
+ assertEquals(minimum_content[p], property_mirror.value().value(),
+ 'property ' + p + ' has unexpected value');
minimum_count++;
}
@@ -152,7 +145,6 @@ function CheckScopeChainPositions(positions, exec_state) {
"FrameMirror.allScopes length");
for (var i = 0; i < positions.length; i++) {
var scope = exec_state.frame().scope(i);
- assertTrue(scope.isScope());
var position = positions[i];
if (!position)
continue;
@@ -408,7 +400,7 @@ listener_delegate = function(exec_state) {
debug.ScopeType.Module,
debug.ScopeType.Script,
debug.ScopeType.Global], exec_state);
- CheckScopeContent({a:1,b:2,x:3,y:4,f:function(){}}, 1, exec_state);
+ CheckScopeContent({a:1,b:2,x:3,y:4,f:undefined}, 1, exec_state);
CheckScopeChainNames(["f", "closure_4", undefined, undefined, undefined],
exec_state)
};
@@ -440,7 +432,7 @@ listener_delegate = function(exec_state) {
debug.ScopeType.Module,
debug.ScopeType.Script,
debug.ScopeType.Global], exec_state);
- CheckScopeContent({a:1,b:2,x:3,y:4,f:function(){}}, 1, exec_state);
+ CheckScopeContent({a:1,b:2,x:3,y:4,f:undefined}, 1, exec_state);
CheckScopeChainNames(["f", "closure_5", undefined, undefined, undefined],
exec_state)
};
@@ -475,7 +467,7 @@ listener_delegate = function(exec_state) {
debug.ScopeType.Script,
debug.ScopeType.Global], exec_state);
CheckScopeContent({a:1}, 1, exec_state);
- CheckScopeContent({f:function(){}}, 2, exec_state);
+ CheckScopeContent({f:undefined}, 2, exec_state);
CheckScopeChainNames(
[undefined, "f", "closure_6", undefined, undefined, undefined],
exec_state);
@@ -515,7 +507,7 @@ listener_delegate = function(exec_state) {
debug.ScopeType.Global], exec_state);
CheckScopeContent({}, 0, exec_state);
CheckScopeContent({a:1,b:2,x:3,y:4}, 1, exec_state);
- CheckScopeContent({a:1,b:2,x:3,y:4,f:function(){}}, 2, exec_state);
+ CheckScopeContent({a:1,b:2,x:3,y:4,f:undefined}, 2, exec_state);
CheckScopeChainNames(
[undefined, "f", "closure_7", undefined, undefined, undefined],
exec_state);

Powered by Google App Engine
This is Rietveld 408576698