Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2566093002: [debug-wrapper] migrate some scope related tests (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug-wrapper] migrate some scope related tests R=jgruber@chromium.org BUG=v8:5530 Committed: https://crrev.com/341b39f9d0d891422c536e04cee7710d9ea8eeab Cr-Commit-Position: refs/heads/master@{#41688}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -4333 lines) Patch
A + test/debugger/bugs/harmony/debug-blockscopes.js View 5 chunks +6 lines, -12 lines 0 comments Download
M test/debugger/debug/debug-backtrace.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/debug-clearbreakpoint.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/debug-evaluate.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/debug-evaluate-bool-constructor.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/debug-return-value.js View 1 3 chunks +0 lines, -4 lines 0 comments Download
A + test/debugger/debug/debug-scopes.js View 1 16 chunks +17 lines, -25 lines 0 comments Download
A + test/debugger/debug/debug-setbreakpoint.js View 3 chunks +6 lines, -16 lines 0 comments Download
A + test/debugger/debug/es6/debug-blockscopes.js View 5 chunks +7 lines, -11 lines 0 comments Download
A + test/debugger/debug/es6/generators-debug-scopes.js View 8 chunks +11 lines, -18 lines 0 comments Download
A + test/debugger/debug/harmony/async-function-debug-scopes.js View 5 chunks +7 lines, -14 lines 0 comments Download
A + test/debugger/debug/ignition/debug-step-prefix-bytecodes.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-1081309.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-1639.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-1853.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/debugger.status View 1 4 chunks +17 lines, -10 lines 0 comments Download
M test/debugger/test-api.js View 7 chunks +55 lines, -5 lines 0 comments Download
D test/mjsunit/bugs/harmony/debug-blockscopes.js View 1 chunk +0 lines, -170 lines 0 comments Download
D test/mjsunit/debug-changebreakpoint.js View 1 chunk +0 lines, -64 lines 0 comments Download
D test/mjsunit/debug-clearbreakpoint.js View 1 chunk +0 lines, -62 lines 0 comments Download
D test/mjsunit/debug-evaluate.js View 1 chunk +0 lines, -87 lines 0 comments Download
D test/mjsunit/debug-evaluate-bool-constructor.js View 1 chunk +0 lines, -65 lines 0 comments Download
D test/mjsunit/debug-evaluate-recursive.js View 1 chunk +0 lines, -116 lines 0 comments Download
D test/mjsunit/debug-evaluate-with-context.js View 1 chunk +0 lines, -120 lines 0 comments Download
D test/mjsunit/debug-return-value.js View 1 chunk +0 lines, -122 lines 0 comments Download
D test/mjsunit/debug-scopes.js View 1 chunk +0 lines, -1268 lines 0 comments Download
D test/mjsunit/debug-setbreakpoint.js View 1 chunk +0 lines, -150 lines 0 comments Download
D test/mjsunit/es6/debug-blockscopes.js View 1 chunk +0 lines, -491 lines 0 comments Download
D test/mjsunit/es6/generators-debug-scopes.js View 1 chunk +0 lines, -291 lines 0 comments Download
D test/mjsunit/harmony/async-function-debug-scopes.js View 1 chunk +0 lines, -557 lines 0 comments Download
D test/mjsunit/ignition/debug-step-prefix-bytecodes.js View 1 chunk +0 lines, -375 lines 0 comments Download
M test/mjsunit/mjsunit.status View 7 chunks +0 lines, -15 lines 0 comments Download
D test/mjsunit/regress/regress-1081309.js View 1 chunk +0 lines, -74 lines 0 comments Download
D test/mjsunit/regress/regress-1639.js View 1 chunk +0 lines, -77 lines 0 comments Download
D test/mjsunit/regress/regress-1853.js View 1 chunk +0 lines, -100 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Yang
4 years ago (2016-12-12 10:38:48 UTC) #1
jgruber
Thanks! lgtm with comments. https://codereview.chromium.org/2566093002/diff/1/test/debugger/debug/debug-return-value.js File test/debugger/debug/debug-return-value.js (right): https://codereview.chromium.org/2566093002/diff/1/test/debugger/debug/debug-return-value.js#newcode43 test/debugger/debug/debug-return-value.js:43: //assertFalse(exec_state.frame(0).isAtReturn()) Can we remove this ...
4 years ago (2016-12-12 13:11:58 UTC) #6
Yang
thanks. addressed comments.
4 years ago (2016-12-14 06:50:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566093002/20001
4 years ago (2016-12-14 06:50:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 07:20:18 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-14 07:20:39 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/341b39f9d0d891422c536e04cee7710d9ea8eeab
Cr-Commit-Position: refs/heads/master@{#41688}

Powered by Google App Engine
This is Rietveld 408576698